feat: allow to import require statements and show all failing with multi-error#2354
Merged
FabianKramm merged 5 commits intodevspace-sh:mainfrom Oct 5, 2022
Merged
Conversation
lizardruss
requested changes
Sep 30, 2022
Collaborator
lizardruss
left a comment
lizardruss
left a comment
There was a problem hiding this comment.
Thanks for the PR!
See my inline comments for requested changes
dtomasi
requested review from
lizardruss
and removed request for
FabianKramm and
LukasGentele
FabianKramm
approved these changes
Oct 3, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@dtomasi thanks for the PR! LGTM!
Collaborator
|
@dtomasi unfortunately the tests are failing, please take a look there! |
Contributor
Author
|
@FabianKramm well ... a stupid mistake in variable assignment caused this. Unfortunately, I cannot see if everything passes now now, as of
However ... Hope this fixes the tests. |
pratikjagrut
changed the title
lizardruss
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2353
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace does not resolve
requirerecursive inimports. Additionally this introduces mutlierror for requirements to output all unmet requirements at once. This is useful if there are a bunch of imports with different requirements.What else do we need to know?