fix: update asset download urls#2301
Merged
FabianKramm merged 1 commit intodevspace-sh:mainfrom Sep 12, 2022
Merged
Conversation
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
lizardruss
force-pushed
the
asset-download-fix
branch
from
3133fdc to
24c71e9
Compare
FabianKramm
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve?
GitHub has updated how the assets on their releases pages are loaded. Instead of being rendered with the initial HTML, they are now loaded asynchronously via JavaScript. Devspace was using the static HTML to determine the URLs to download supporting assets. This PR modifies the download URLs to rely on
https://github.com/loft-sh/devspace/releases/download/[VERSION]/[ASSET]style download URLs.Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace could not download the DevSpace UI and the
devspacehelper