Skip to content

fixes:#4 Added example react app. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2019

Conversation

ganesh-4212
Copy link
Contributor

Added example react app.

Copy link
Owner

@devshawn devshawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea, thanks so much for this!

Just a few changes:

  • Let's remove a few of the "unneeded" files for the example. For example, the service worker file could be removed as it isn't really needed to show the react-dayjs example.
  • Can we update the example README to be more concise (i.e. how to run the example and what it is showing) rather than the default create-react-app README?
  • The tests fail on Travis, it looks like it can't find the react-dayjs module when the example app tests are run. This should get fixed before we can merge this in.

Thanks again!

@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          37     37           
  Branches       12     12           
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ac772...7b3e071. Read the comment docs.

@devshawn devshawn self-requested a review June 5, 2019 20:20
Copy link
Owner

@devshawn devshawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a bunch for this!

@devshawn devshawn merged commit aad9ebf into devshawn:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants