Skip to content

Transformed Component to Hooks-API #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2020
Merged

Conversation

miallo
Copy link
Contributor

@miallo miallo commented Oct 16, 2020

Hello!
Since componentWillMount was renamed and is discouraged to use and there were warnings in the command line, I transformed the class based Component to the new Hooks-API.

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           37        39    +2     
  Branches        12        12           
=========================================
+ Hits            37        39    +2     
Impacted Files Coverage Δ
source/index.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe117f...9cab552. Read the comment docs.

@miallo
Copy link
Contributor Author

miallo commented Oct 16, 2020

(Sorry for the commits. I think I should run and fix the tests first... 😃)

@miallo
Copy link
Contributor Author

miallo commented Oct 16, 2020

That took some time 😄

@devshawn
Copy link
Owner

Hi @miallo, thank you very much for your contribution! I appreciate you updating react-dayjs to the hooks API!

I've seen you make a few commits -- let me know when you're finished and I'll review and merge it in!

@miallo
Copy link
Contributor Author

miallo commented Oct 16, 2020

I hope I am done now ;)

@devshawn devshawn merged commit fe227f9 into devshawn:master Oct 16, 2020
@miallo miallo deleted the react-hooks-api branch October 16, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants