Skip to content

feat: remove zookeeper dependency from kafka-topics #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

devshawn
Copy link
Owner

Description

Removes zookeeper dependency from kafka-topics. It seems the other commands using zookeeper still require it. This is for support with Confluent Cloud clusters.

@devshawn devshawn force-pushed the kafka-topics-support branch from 25f77fe to cad1da7 Compare February 11, 2020 02:53
@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #20 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   96.86%   96.89%   +0.02%     
==========================================
  Files          12       12              
  Lines         575      580       +5     
==========================================
+ Hits          557      562       +5     
  Misses         18       18
Impacted Files Coverage Δ
kafkashell/executor.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29fefd...6ad955a. Read the comment docs.

@devshawn devshawn force-pushed the kafka-topics-support branch from cad1da7 to 04e2e77 Compare February 11, 2020 02:59
@devshawn devshawn force-pushed the kafka-topics-support branch from 04e2e77 to 6ad955a Compare February 11, 2020 03:32
@devshawn devshawn merged commit f85139a into master Feb 11, 2020
@devshawn devshawn deleted the kafka-topics-support branch February 11, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants