Skip to content

add: plug script #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 14, 2025
Merged

add: plug script #224

merged 32 commits into from
May 14, 2025

Conversation

nikhiltidke101
Copy link
Collaborator

@nikhiltidke101 nikhiltidke101 commented May 13, 2025

@nikhiltidke101 nikhiltidke101 requested a review from a team as a code owner May 13, 2025 11:00
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

…d data

- Changed the app ID assignment in the Plug SDK initialization to retrieve the ID from the fetched data instead of using an environment variable.
- Updated the `getPageData` function to include the `plug` object containing the ID fetched from the Sanity database.
Copy link
Contributor

- Introduced a new `Search` component to facilitate search functionality.
- Integrated the `Search` component into the main application, replacing the existing search button with the new component.
- Ensured the search button is rendered only if certain conditions are met, enhancing the application's dynamic behavior.
Copy link
Contributor

- Commented out the initialization code for the `ThemeSwitch` and `search-component-wrapper` to streamline the rendering process.
- This change prepares the code for potential future enhancements without removing the existing structure.
Copy link
Contributor

- Removed commented-out code for `theme-switch` initialization and adjusted the rendering logic for the `Search` component.
- The `Search` component is now directly appended to the `searchWrapper`, enhancing the structure and clarity of the rendering process.
- Eliminated the unused sidenav code related to the search bar to enhance code clarity and maintainability.
- This change contributes to a cleaner rendering process in the main application.
Copy link
Contributor

- Replaced the search button with the search component by targeting the parent element of the button.
- Enhanced the rendering logic to ensure the search component is integrated correctly within the sidebar.
- This change improves the clarity and maintainability of the rendering process.
Copy link
Contributor

- Commented out the rendering logic for the `Search` component and `ThemeSwitch` to streamline the integration process.
- This change maintains the existing structure while preparing for potential future enhancements.
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

…tch and search components in main application
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@iarthstar iarthstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does CMD + K work ???

did you try searching ???

Copy link
Collaborator

@iarthstar iarthstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@nikhiltidke101 nikhiltidke101 merged commit 9d8db91 into main May 14, 2025
4 checks passed
@nikhiltidke101 nikhiltidke101 deleted the feat/plug branch May 14, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants