-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Move chef-cli docs to fern #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email support@ekline.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
EkLine
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- [jq](https://stedolan.github.io/jq) |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- [golang](https://go.dev/doc/install) |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- [nodejs](https://nodejs.org/en/download/package-manager) (version 18.x.x+ or higher) |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
1. Create an import at **Settings** > **Imports** > **Import**. |
Published docs preview URL: https://devrev-preview-90c66bf2-3f81-41d0-a259-f7836e0d67c5.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-5398c69b-dd6c-4859-82f0-e6dfda8ec59a.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
EkLine
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This mapping, unlike the recipe blueprint of a concrete import, can contain multiple options for each external record type from which the end-user might choose (for example allow *task* from an external system to map either to *issue* or *ticket* in DevRev), and it can contain also mappings that apply to a record type category. When the user runs a new import, and the extractor reports in its metadata record types belonging to this category, that are not directly mapped in the initial domain mappings, the recipe manager will apply the per-category default to them. |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- raw jq transformations using an external field as input. (This is an experimental feature) |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This will output any problems there may be with the metadata file. |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Contain the same type of records, named after their type |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Have .json or .jsonl extension, for example `issues.json` |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Contain either a single JSON array of objects, or newline-separated objects |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
2. Run the `infer-metadata` command targeting this directory |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
3. Inspect the generated metadata, particularly field types and the suggestions the tool generates |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Provide 10-100 examples of each record type (but not more than 1000) |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Ensure logically distinct fields are separate keys at the top level |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Use referentially consistent example data if possible |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- Make sure IDs are strings, not numbers |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This generated metadata serves as a starting point that will need further refinement. It can be used to prototype initial domain mappings (by running a sync with it) and to generate example normalized data, but it is still just a guess: It has to be reviewed and refined. |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
`is_write_only` etc. By default these will be set to false. You can find the full list of supported |
🚫 [EkLine] reported by reviewdog 🐶
Prefer English terms over Latin abbreviations. Use 'for example' instead of 'e.g.'. (EK00026)
possible (e.g., to move to the 'resolved' status, an issue first has to be 'in_testing'), you |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
This will allow creation of a matching 'stage diagram' (a collection of stages and their permitted |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- The status field is the controlling field of the stage diagram |
🚫 [EkLine] reported by reviewdog 🐶
Suggestions:
- Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
- Must put the ending punctuation at the end of a list item. (EK00041)
- If a status field has no explicit transitions but you still want a stage diagram, set `all_transitions_allowed` to `true`, which will create a diagram where all the defined stages can transition to each other |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- External systems may categorize statuses (like Jira's status categories), which can be included in the diagram metadata (`states` in the example) |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
- The `starting_stage` defines the initial stage for new object instances. This data should always be provided if available, otherwise the starting stage will be selected alphabetically |
🚫 [EkLine] reported by reviewdog 🐶
Must put the ending punctuation at the end of a list item. (EK00041)
- In current metadata format (v0.2.0), the order and human-readable name are taken from the enum values defined on the controlling field |
🚫 [EkLine] reported by reviewdog 🐶
Suggestions:
- Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
- Must put the ending punctuation at the end of a list item. (EK00041)
- If the `states` field is not provided, default DevRev states will be used: `open`, `in_progress` and `closed` |
Published docs preview URL: https://devrev-preview-975f1dc4-ce55-47c2-b105-1b097a94570e.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-bff63461-6108-4a4c-9b68-e2db9b1e5b62.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-0d3ee3c4-fb65-4072-a607-411e58922de3.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-a7a8d656-e518-4ae3-9d17-af2d1167d0c3.docs.buildwithfern.com |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Published docs preview URL: https://devrev-preview-8bcb901b-5486-453d-810a-a900408c4d5f.docs.buildwithfern.com |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Published docs preview URL: https://devrev-preview-7b1f8b81-3cac-448c-b9cc-c52d7dfddc63.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-1334cc5a-bda7-4ea6-bf53-9a51effd9e6c.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-d1ed6ee4-b31e-4e11-b8a8-110e4aa775c4.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-40009eea-fe92-4617-96ab-98585f0cad25.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-68f1fc37-f674-4437-8c67-d0aab45c0cee.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are so many changes I didn't manage to read them all, but the overall gist looks fine
Published docs preview URL: https://devrev-preview-9f8a000c-8410-4bce-beef-3603fa04cf70.docs.buildwithfern.com |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Published docs preview URL: https://devrev-preview-aee0297b-fcb5-4ed9-963b-fe742392abd2.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-582349fa-8585-4169-86cc-4815b83145a7.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some suggestions.
Published docs preview URL: https://devrev-preview-5c9bbd1d-759a-4a75-97c2-7709587befbe.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-343ec41a-0c18-4ebb-88d5-846677942390.docs.buildwithfern.com |
This brings in documentation from the chef-cli repository. This first version improves metadata extraction and adds IDM.
There is also a framework do add the rest under the Data model folder, but this is hidden for now.
https://app.devrev.ai/devrev/works/ISS-154217