8_refactor_modules #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version with factory inside of the refactored class
version with factory inside of the refactored class force usage of interface
version with factory extracted level up Also we use separated interface and order adapter to separate shitty library coupling
New calculations will be added (bad way)
adding discount based on client discount for shipping
adding premium box cost into delivery
adding special days discounts (free delivery)
adding special days discounts (free delivery)
stuck in a problem of injected elements in interfaces/classes
decorator done
extract methods - DRY
create abstract decorator and remove repeated code - DRY
create abstract decorator and remove repeated code - DRY
move CountryCalc factory into ShippingCostCalculator.php
rename country calc into OrderTotal calc
first working wersion
DRY - simplify PremiumBox decorators
create specified country calculator builders
…ule breaking) The boxing is extracted as separated decorator (and it's nto a part of AdditionalCalculations line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.