Skip to content

Consider making the new manage_guest setting true by default #177

Closed
@bowlofeggs

Description

@bowlofeggs

I'm not a Ruby dev so I may be reading the code wrong, but it seems to me that the behavior in 1.7.1 was to always manage the guest's hosts file and it seems that in 1.8.0 it only manages it if the user explicitly defines a setting. I'm basing that on the default:

https://github.com/smdahlen/vagrant-hostmanager/blob/6f4c0d7c6a5f2365e1353f7fec08950a5c874c3c/lib/vagrant-hostmanager/config.rb#L30

This would make 1.8.0 backwards-incompatible with 1.7.1 which some users may find surprising since it's a Y release. Would you consider swapping the default to true and releasing a 1.8.1 with that, (assuming that I've interpreted the code correctly? Apologies if I am mistaken…)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions