Support suppressing to apply curations #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohecker
requested changes
Mar 4, 2024
...src/main/java/com/devonfw/tools/solicitor/componentinfo/ComponentInfoInventoryProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/devonfw/tools/solicitor/componentinfo/curation/ComponentInfoCurator.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/devonfw/tools/solicitor/componentinfo/curation/ComponentInfoCuratorImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/devonfw/tools/solicitor/componentinfo/curation/ComponentInfoCuratorImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/devonfw/tools/solicitor/componentinfo/curation/ComponentInfoCurator.java
Outdated
Show resolved
Hide resolved
| @@ -1669,6 +1669,8 @@ Spring beans implementing this interface will be called at certain points in the | |||
| == Release Notes | |||
| Changes in 1.20.0:: | |||
| * https://github.com/devonfw/solicitor/issues/232: Set a standard for ordering LicenseNameMapping rules. Rules with an 'or-later' suffix are put before '-only' rules. | |||
| * https://github.com/devonfw/solicitor/pull/235: Enhanced Curation Template Generation. when generating a curation template and setting the curationdataselector parameter to "none," curations will be skipped, resulting in a template without applied curations. | |||
There was a problem hiding this comment.
The comment in "application.properties" (in core/src/main/resources as well as in the copy in documentation/files) needs to be extended to describe the special value "none".
...om/devonfw/tools/solicitor/componentinfo/scancode/FilteredScancodeComponentInfoProvider.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/devonfw/tools/solicitor/componentinfo/curating/ComponentInfoCuratorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/devonfw/tools/solicitor/componentinfo/curating/ComponentInfoCuratorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/devonfw/tools/solicitor/componentinfo/curating/ComponentInfoCuratorTest.java
Outdated
Show resolved
Hide resolved
…ature/curations_template_WO_applied # Conflicts: # documentation/master-solicitor.asciidoc
…b.com/mahmoudAlkam/solicitor into feature/curations_template_WO_applied
ohecker
changed the title
ohecker
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.