Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in processing of ScanCode results #171

Closed
ohecker opened this issue Apr 27, 2023 · 0 comments · Fixed by #173
Closed

Improvements in processing of ScanCode results #171

ohecker opened this issue Apr 27, 2023 · 0 comments · Fixed by #173
Assignees
Labels
enhancement New feature or request

Comments

@ohecker
Copy link
Member

ohecker commented Apr 27, 2023

The experimental ScanCode integration should be improved, to better make use of the Scancode results in Solicitor

  • When ScanCode rules detect license findings the result data not just contains information on the file where the license was detected but also indicates the respective line numbers where the license was found. This information should be used to reduce the amount of text to be displayed/printed within reports (i.e. not printing a complete file but only the relevant header lines).
  • ScanCode reports the "Classpath-exception-2.0" as a separate license. Within Solicitor this exception is normally represented together with the corresponding base license like "GPL-2.0-only WITH Classpath-exception-2.0". The conversion from ScanCode data to the internal Solicitor data should try to handle this.
  • If ScanCode data is available for a component then the license data possibly already existing for this component (from the Reader data) is deleted. If the ScanCode data itself does not contain any license information for this component then the component will be left without any license information. This might even result in such a component not being reported at all. In such cases the license info coming from the Readers should be preserved.
  • The "scancode_text_url" might point to a file located at https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses. This resource not just contains the license text itself but also some YAML encoded metadata on the license. Any such URLs should be rewritten to point to https://scancode-licensedb.aboutcode.org. The resources available there are the plain license texts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant