#1218: optimized gradle url-updater #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made version regex pattern more distinct added hashsum param to doAddVersion added doGetHashSumForVersion method (can extract a valid hashsum for a given version) moved regex patterns and URLs into constants
hohwille
reviewed
Jun 30, 2023
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/gradle/GradleUrlUpdater.java
Outdated
Show resolved
Hide resolved
added lazy loading of responseBody added extra check for empty checksum moved download Url into constant
hohwille
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
@jan-vcapgemini Excellent. Thanks for the final polishing. Now everything is perfect.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses/Fixes: #1218
Implements: