-
Notifications
You must be signed in to change notification settings - Fork 103
Fix SONAR_HOME path variable for Windows #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR. IMHO the "old" value is still the official env variable: I think we can still change it as we mainly use this internally but maybe it is also good to leave it as is in case sonarqube will also use this variable... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now I got it. In our script we already changed the variable to SONAR_HOME but forgot to also update other occurrences referencing the variable.
Thanks for fixing
This PR is a quick fix for a path variable in
sonarcommand scriptide/scripts/src/main/resources/scripts/command/sonar
Lines 42 to 45 in 015e8fa