Skip to content

Conversation

@alfeilex
Copy link
Member

@alfeilex alfeilex commented Jun 28, 2023

This PR is a quick fix for a path variable in sonar command script

"${SONARQUBE_HOME}/bin/windows-x86-64/StartSonar.bat"
elif [ "${1}" = "stop" ]
then
"${SONARQUBE_HOME}/bin/windows-x86-64/SonarService.bat" stop

@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Jun 28, 2023
@alfeilex alfeilex marked this pull request as ready for review June 28, 2023 11:50
@hohwille hohwille linked an issue Jun 30, 2023 that may be closed by this pull request
@hohwille
Copy link
Member

Thanks for your PR. IMHO the "old" value is still the official env variable:
https://docs.sonarqube.org/9.7/setup-and-upgrade/configure-and-operate-a-server/operating-the-server/

I think we can still change it as we mainly use this internally but maybe it is also good to leave it as is in case sonarqube will also use this variable...

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I got it. In our script we already changed the variable to SONAR_HOME but forgot to also update other occurrences referencing the variable.

Thanks for fixing

@hohwille hohwille added this to the release:2023.06.001 milestone Jun 30, 2023
@hohwille hohwille merged commit 7d17ca0 into devonfw:master Jun 30, 2023
@alfeilex alfeilex deleted the alfeilex-patch-1 branch July 5, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align tool names in scripts

2 participants