Skip to content

#1132 - Determine tool versions of intellij with jsonurlupdater #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 4, 2023
Merged

#1132 - Determine tool versions of intellij with jsonurlupdater #1205

merged 17 commits into from
Jul 4, 2023

Conversation

@diiinesh
Copy link
Contributor

Enhances: #1132

Implements

  • IntellijJsonDownloadItemProp.java
  • IntellijJsonDownloads.java
  • IntellijJsonDownloadsItem.java
  • IntellijJsonObject.java
  • IntellijJsonReleases.java
  • IntellijUrlUpdater.java
  • java\com\devonfw\tools\ide\integrationtests\IntellijUrlUpdaterMock.java
  • resources\integrationtests\JsonUrlUpdater*

Removed:

  • IntellijCommunityUrlUpdater.java
  • IntellijUltimateUrlUpdater.java

diiinesh added 7 commits June 1, 2023 11:26
@diiinesh
#1132 - implemented reading version, checksum from json provided by i…
c09b936 
…ntellij

Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
@diiinesh
Merge branch 'intellijUrlVersion'
87907bf
@diiinesh
Merge remote-tracking branch 'origin/master'
c0feaee
@diiinesh
#1132 - implemented reading version, checksum from json provided by i…
24ed77e 
…ntellij, added tests

Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
@diiinesh
Merge remote-tracking branch 'origin/master'
de64ebe
@diiinesh
Reset UpdateManager.java
7887edc 
Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
@diiinesh
Merge remote-tracking branch 'origin/master'
28eb16d
@diiinesh diiinesh requested a review from jan-vcapgemini June 22, 2023 08:48
@github-actions github-actions bot added the bash related to bash shell or scripts label Jun 22, 2023
@sonatype-lift
Copy link

sonatype-lift bot commented Jun 22, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/devonfw/ide/1205.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/devonfw/ide/1205.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser. ↩

@diiinesh
Reset UpdateManager.java
af0c7eb 
Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
changed function getCheckSum in IntellijUrlUpdate, more efficently coded
@diiinesh diiinesh closed this Jun 22, 2023
@diiinesh diiinesh reopened this Jun 22, 2023
@diiinesh diiinesh removed the request for review from jan-vcapgemini June 22, 2023 12:08
@diiinesh
Reset UpdateInitiator.java
bbff773 
Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
jan-vcapgemini
jan-vcapgemini reviewed Jun 29, 2023
View reviewed changes
diiinesh added 3 commits June 29, 2023 12:57
@diiinesh
Merge remote-tracking branch 'origin/master'
9b9632e 
# Conflicts:
#	url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java
@diiinesh
Merge branch 'master' into 1132-intellijurlupdate
adb358b
@diiinesh
Removed timestamp from json url
bbf97c3 
edited links in test json file

Signed-off-by: diiinesh <63147290+diiinesh@users.noreply.github.com>
@diiinesh diiinesh requested a review from hohwille June 29, 2023 13:42
@hohwille hohwille linked an issue Jul 3, 2023 that may be closed by this pull request
Replace WebsiteUrlUpdater with JsonUrlUpdater #1172
Closed
@hohwille hohwille added this to the release:2023.07.001 milestone Jul 3, 2023
@hohwille hohwille linked an issue Jul 3, 2023 that may be closed by this pull request
Use reliable ways to determine tool versions for intellij #1132
Closed
@jan-vcapgemini
#1132: fixed intellijUrlUpdater
ae0e5be 
refactored JsonUrlUpdaterIT classes and resoruces to AndroidJsonUrlUpdaterIT and IntellijJsonUrlUpdaterIT
fixed integration tests
renamed integrationtests package and folders to integrationtest
@jan-vcapgemini
Merge branch 'master' into 1132-intellijurlupdate
a001d61
@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review July 3, 2023 15:38
@jan-vcapgemini jan-vcapgemini self-assigned this Jul 3, 2023
@jan-vcapgemini
#1132: refactorings
2fb5cec
@jan-vcapgemini
#1132: refactorings
9c65eb5 
changed package name from uppercase to lowercase
@jan-vcapgemini
#1132: refactorings
fd74922 
added new addVersionForEdtion method
removed getEdition override
removed edtionSwitch
hohwille
hohwille approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diiinesh and @jan-vcapgemini: Very nice work you did with this PR 👍
Ready for merge now.

@hohwille
Copy link
Member

hohwille commented Jul 4, 2023

I can not see any open lift issue directly in this PR.
Also I downloaded the auto-generated diff that was praised from lift and it is empty.
However, lift is marking the check as red blocking this PR.

@hohwille hohwille merged commit d5796d6 into devonfw:master Jul 4, 2023
@hohwille hohwille mentioned this pull request Jul 4, 2023
Closed
@hohwille hohwille mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini jan-vcapgemini left review comments

+1 more reviewer

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jan-vcapgemini jan-vcapgemini

Labels

bash related to bash shell or scripts

Projects

None yet

Milestone

release:2023.07.001

Development

Successfully merging this pull request may close these issues.

Replace WebsiteUrlUpdater with JsonUrlUpdater Use reliable ways to determine tool versions for intellij

3 participants

@diiinesh @hohwille @jan-vcapgemini