Skip to content

#1086 Align tool names in ide-urls #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2023
Merged

#1086 Align tool names in ide-urls #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd3e96
Aligned tool names in ide-urls
moritzLanger Apr 25, 2023
2b2b8cb
Changed MavenBaseRepoUrl name to mvnBaseRepoUrl
moritzLanger Apr 25, 2023
5739c63
changed Mvn Crawler to MavenBasedCrawler
moritzLanger Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...w/tools/ide/url/updater/MavenCrawler.java → ...ls/ide/url/updater/MavenBasedCrawler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
/**
* The MvnCrawler class is an abstract class that provides functionality for crawling Maven repositories.
*/
public abstract class MavenCrawler extends AbstractCrawler {
private final static Logger logger = LoggerFactory.getLogger(MavenCrawler.class.getName());
public abstract class MavenBasedCrawler extends AbstractCrawler {
private final static Logger logger = LoggerFactory.getLogger(MavenBasedCrawler.class.getName());
private final String mavenBaseRepoUrl;

public MavenCrawler() {
public MavenBasedCrawler() {
super();
this.mavenBaseRepoUrl = "https://repo1.maven.org/maven2/" + getGroupIdPath() + "/" + getArtifcatId() + "/";

Expand Down
6 changes: 3 additions & 3 deletions url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
import com.devonfw.tools.ide.url.updater.kotlin.KotlinNativeCrawler;
import com.devonfw.tools.ide.url.updater.lazydocker.LazyDockerCrawler;
import com.devonfw.tools.ide.url.updater.mvn.MvnCrawler;
import com.devonfw.tools.ide.url.updater.nodejs.NodeJsCrawler;
import com.devonfw.tools.ide.url.updater.node.NodeCrawler;
import com.devonfw.tools.ide.url.updater.npm.NpmCrawler;
import com.devonfw.tools.ide.url.updater.oc.OcCrawler;
import com.devonfw.tools.ide.url.updater.pip.PipCrawler;
import com.devonfw.tools.ide.url.updater.python.PythonCrawler;
import com.devonfw.tools.ide.url.updater.quarkus.QuarkusCrawler;
import com.devonfw.tools.ide.url.updater.rancher.RancherCrawler;
import com.devonfw.tools.ide.url.updater.sonarqube.SonarqubeCrawler;
import com.devonfw.tools.ide.url.updater.sonar.SonarCrawler;
import com.devonfw.tools.ide.url.updater.terraform.TerraformCrawler;
import com.devonfw.tools.ide.url.updater.vscode.VSCodeCrawler;

Expand All @@ -43,7 +43,7 @@
*/
public class UpdateManager {
private final UrlRepository urlRepository;
private final List<AbstractCrawler> crawlers = Arrays.asList(new AWSCrawler(), new AzureCrawler(), new CobigenCrawler(), new DotNetCrawler(), new DockerCrawler(), new EclipseCppCrawler(), new EclipseEclipseCrawler(), new GCViewerCrawler(), new GHCrawler(), new GraalVMCrawler(), new GradleCrawler(), new HelmCrawler(), new IntelliJUltimateEditionCrawler(), new IntelliJIntellijEditionCrawler(), new JavaCrawler(), new JenkinsCrawler(), new KotlinCrawler(), new KotlinNativeCrawler(), new LazyDockerCrawler(), new MvnCrawler(), new NodeJsCrawler(), new NpmCrawler(), new OcCrawler(), new PipCrawler(), new PythonCrawler(), new QuarkusCrawler(), new RancherCrawler(), new SonarqubeCrawler(), new TerraformCrawler(), new VSCodeCrawler());
private final List<AbstractCrawler> crawlers = Arrays.asList(new AWSCrawler(), new AzureCrawler(), new CobigenCrawler(), new DotNetCrawler(), new DockerCrawler(), new EclipseCppCrawler(), new EclipseEclipseCrawler(), new GCViewerCrawler(), new GHCrawler(), new GraalVMCrawler(), new GradleCrawler(), new HelmCrawler(), new IntelliJUltimateEditionCrawler(), new IntelliJIntellijEditionCrawler(), new JavaCrawler(), new JenkinsCrawler(), new KotlinCrawler(), new KotlinNativeCrawler(), new LazyDockerCrawler(), new MvnCrawler(), new NodeCrawler(), new NpmCrawler(), new OcCrawler(), new PipCrawler(), new PythonCrawler(), new QuarkusCrawler(), new RancherCrawler(), new SonarCrawler(), new TerraformCrawler(), new VSCodeCrawler());

public UpdateManager(Path pathToRepository) {
this.urlRepository = UrlRepository.load(pathToRepository);
Expand Down
4 changes: 2 additions & 2 deletions url-updater/src/main/java/com/devonfw/tools/ide/url/updater/cobigen/CobigenCrawler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.devonfw.tools.ide.url.updater.cobigen;

import com.devonfw.tools.ide.url.updater.MavenCrawler;
import com.devonfw.tools.ide.url.updater.MavenBasedCrawler;


public class CobigenCrawler extends MavenCrawler {
public class CobigenCrawler extends MavenBasedCrawler {
@Override
protected String getToolName() {
return "cobigen";
Expand Down
6 changes: 3 additions & 3 deletions ...ide/url/updater/nodejs/NodeJsCrawler.java → ...ols/ide/url/updater/node/NodeCrawler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package com.devonfw.tools.ide.url.updater.nodejs;
package com.devonfw.tools.ide.url.updater.node;

import com.devonfw.tools.ide.url.folderhandling.UrlVersion;
import com.devonfw.tools.ide.url.updater.GithubCrawler;
import com.devonfw.tools.ide.url.updater.OSType;

public class NodeJsCrawler extends GithubCrawler {
public class NodeCrawler extends GithubCrawler {
@Override
protected String getToolName() {
return "nodejs";
return "node";
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions ...l/updater/sonarqube/SonarqubeCrawler.java → ...s/ide/url/updater/sonar/SonarCrawler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package com.devonfw.tools.ide.url.updater.sonarqube;
package com.devonfw.tools.ide.url.updater.sonar;

import com.devonfw.tools.ide.url.folderhandling.UrlVersion;
import com.devonfw.tools.ide.url.updater.GithubCrawler;

public class SonarqubeCrawler extends GithubCrawler {
public class SonarCrawler extends GithubCrawler {
@Override
protected String getToolName() {
return "sonarqube";
return "sonar";
}

@Override
Expand Down