Skip to content

Conversation

@CREITZ25
Copy link
Member

#1054 automated security warnings

#1054 automated security warnings
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Mar 19, 2023
@CREITZ25 CREITZ25 linked an issue Mar 19, 2023 that may be closed by this pull request
#1054 automated security warnings
#1054 automated security warnings
@CREITZ25
Copy link
Member Author

CREITZ25 commented Mar 19, 2023

When the commands devon setup and devon ide update software are called, the version of the software to be installed is checked for security gaps using the information in the Security file and a corresponding message is output if necessary. The security file may be stored in mirrors/ as well as in ide-urls// and the formatting for versionintervals was taken into account:
' 2.9.20>2.9.22
' >2.8.10
' 2.8.13
The different variablenames and values for the edition will be adjusted.
The messages are output in such a way that they could also be output collectively at the end of the command, but are currently output immediately.
The Git version is tested with the devon ide... command.

File https://github.com/devonfw/ide/blob/master/documentation/vulnerabilities.asciidoc is not created yet!

#1054 automated security warnings
@CREITZ25 CREITZ25 marked this pull request as ready for review March 19, 2023 15:09
@CREITZ25 CREITZ25 closed this by deleting the head repository Mar 27, 2023
@CREITZ25 CREITZ25 reopened this Mar 27, 2023
@CREITZ25
Copy link
Member Author

Closed and Reopen, because of Github Problems

@CREITZ25 CREITZ25 changed the title #1054 automated security warnings #1054 automated security warnings - save changes Mar 27, 2023
@CREITZ25 CREITZ25 changed the title #1054 automated security warnings - save changes #1054 automated security warnings - saved changes Mar 27, 2023
@hohwille hohwille marked this pull request as draft March 27, 2023 14:58
@hohwille
Copy link
Member

This PR is replaced by #1083
However, some changes here shall not be lost and may be recovered for future improvements after #1083 has been merged.

@hohwille
Copy link
Member

I am finally closing this PR as all information will still be preserved whenever we need them.
To summarize: Here we started to solve the problem that an important error or warning is raised during a complex process but further log-messages will "spam" it away. If the user took his promised coffee and comes back the message might already be scrolled out of sight. In our new Java based product it will be much easier to solve this problem cleanly so I am unsure if we will ever solve it in the bash world.

However, this is not going to be merged and while a PR remains open it continuously gains my attention if I have something left to do...

@hohwille hohwille closed this Aug 10, 2023
@hohwille hohwille added this to the rejected milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

automated security warnings

2 participants