#1007: implement domain model for ide-urls #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlDownloadFile.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlStatusFile.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlStatusFile.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlArtifact.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/devonfw/ide/1040.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/devonfw/ide/1040.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
hohwille
requested changes
Jan 23, 2023
There was a problem hiding this comment.
@cinnamon-coder-hub thanks for your PR. You have properly isolated the required changes to this PR so it is much simpler to get this merged first. 👍
I have added some comments. Can you check and do some rework?
I also tend to refactor the packages but IMHO this should be done after both model and updates are merged to avoid merge efforts...
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlStatusFile.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Outdated
Show resolved
Hide resolved
...main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/JsonDataBlockForSpecificUrl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/UrlJsonCompleteDataBlock.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlStatusFile.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlArtifact.java
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlVersion.java
Show resolved
Hide resolved
hohwille
changed the title
This was referenced Feb 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is based on state of PR #1000 with a few minor changes, to split review into two parts (addressing issues #1007 and #1009) and to avoid further problems with a bug related to the modified settings folder in PR #1000.