Skip to content

#623: fix CliArgument prepend/append #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2024
Merged

#623: fix CliArgument prepend/append #624

merged 6 commits into from
Sep 20, 2024

Conversation

@hohwille
Copy link
Member

Fixes #623
Intentionally I did not change Eclipse from prepend to append since I think this is desired here.

@hohwille hohwille added CLI IDEasy command-line-interface (parsing args, etc.) bugfix core FileAccess, ProcessUtil, IdeContext, etc. labels Sep 17, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10954846753

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 65.733%
Totals Coverage Status
Change from base Build 10954566893: 0.005%
Covered Lines: 6018
Relevant Lines: 8817
💛 - Coveralls

@hohwille hohwille self-assigned this Sep 17, 2024
slskiba
slskiba approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@slskiba slskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Looks good 👍

jan-vcapgemini
jan-vcapgemini approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready for merge.

@hohwille hohwille merged commit 22a0d13 into devonfw:main Sep 20, 2024
3 checks passed
@hohwille hohwille added the story-reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this pull request Mar 7, 2025
@jan-vcapgemini
devonfw#624: implemented requested changes
de17c23 
adjusted changelog
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this pull request Mar 7, 2025
@jan-vcapgemini
devonfw#624: implemented requested changes
82c4511 
moved testCheckPluginInstallation from IdeToolCommandletTest to IntellijTest
moved testCheckEditionConflictInstallation from IdeToolCommandletTest to IntellijTest
Adjusted IntellijTest testIntellijPluginInstallWithCustomRepoUrl to use install instead of run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

+1 more reviewer

@slskiba slskiba slskiba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hohwille hohwille

Labels

bugfix CLI IDEasy command-line-interface (parsing args, etc.) core FileAccess, ProcessUtil, IdeContext, etc. story-reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2024.09.002

Development

Successfully merging this pull request may close these issues.

CliArgument prepend and append methods inconsistent

4 participants

@hohwille @coveralls @jan-vcapgemini @slskiba