Skip to content

#223 dynamic wiremock ports #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 1, 2024
Merged

#223 dynamic wiremock ports #487

merged 14 commits into from
Aug 1, 2024

Conversation

@slskiba
Copy link
Contributor

@slskiba slskiba commented Jul 23, 2024 •
edited
Loading

Closes #223 and closes #193

@slskiba slskiba self-assigned this Jul 23, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10195653418

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.742%
Totals Coverage Status
Change from base Build 10180635803: 0.0%
Covered Lines: 5504
Relevant Lines: 8441
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Finally we can use dynamic ports for WireMock.
I've added some very small CRs (just to please my IDE).

@slskiba slskiba requested a review from jan-vcapgemini July 23, 2024 11:28
jan-vcapgemini
jan-vcapgemini approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ready for review.

@slskiba slskiba mentioned this pull request Jul 25, 2024
Merged
@slskiba
Copy link
Contributor Author

slskiba commented Jul 25, 2024 •
edited
Loading

PR #433 will bring new tests with fixed ports, that should also be adjusted as part of this PR. Converting to draft.

@slskiba slskiba marked this pull request as draft July 25, 2024 12:54
hohwille
hohwille approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for your PR. This looks really good to me and is IMHO ready for merge. Nice job 👍
Do you have some known issues I am missing or why is this PR still in draft mode? Build already succeeded so you did not break the wiremock tests and now they should also work if port 8080 is already used by another app what is often the case on my machine...

@slskiba
Copy link
Contributor Author

slskiba commented Jul 29, 2024

@hohwille as stated above, this PR is waiting for the merge of #433 as it brings new tests with fixed ports, so that they can also be immediately adjusted to use dynamic ports before merging this.

@hohwille
Copy link
Member

@hohwille as stated above, this PR is waiting for the merge of #433 as it brings new tests with fixed ports, so that they can also be immediately adjusted to use dynamic ports before merging this.

Is merged meanwhile. I just updated this branch/PR so you should have the TODO if you pull and can resolve this last spot as well and then this should be ready.
Thanks for explanation and taking care of everything 👍

slskiba added 2 commits July 31, 2024 09:58
@slskiba
Use dynamic port for IntelliJTest
c3b87e2
@slskiba
Merge branch 'main' into feature/223-dynamic-wiremock-ports
eae1f77 
# Conflicts:
#	cli/src/test/java/com/devonfw/tools/ide/tool/python/PythonUrlUpdaterTest.java
#	cli/src/test/resources/integrationtest/PythonJsonUrlUpdater/python-version.json
@slskiba slskiba marked this pull request as ready for review July 31, 2024 08:16
hohwille
hohwille reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for completing. 👍
I found a small problem and being pointed to that I also left a second comment with a similar pattern that is not wrong but should be improved.
Can you please again have a look? Thanks in advance!

@hohwille hohwille self-assigned this Aug 1, 2024
hohwille
hohwille approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba fast and perfect addressing of my review comments. Great job 🚀

@hohwille hohwille merged commit 03e23ec into devonfw:main Aug 1, 2024
@hohwille hohwille added this to the release:2024.08.001 milestone Aug 1, 2024
@hohwille hohwille added test related to testing and QA enhancement New feature or request labels Aug 1, 2024
@hohwille hohwille added the story-reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

@slskiba slskiba

Labels

enhancement New feature or request story-reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. test related to testing and QA

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2024.08.001

Development

Successfully merging this pull request may close these issues.

Alter WireMock tests to use dynamic ports. Change WireMock port

4 participants

@slskiba @coveralls @hohwille @jan-vcapgemini