#1521: Use wiremock for npm repository. #1529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wustudent
added
test
Pull Request Test Coverage Report for Build 18680241255Details
💛 - Coveralls |
|
It looks like some files are missing for this test as the pipeline now throws this exception: Should we add the missing file or ignore this exception as it is not required for this test to be checked? |
jan-vcapgemini
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
@wustudent thanks for your fix. Apart from the exception in the pipeline, the test works as expected now. Ready for review.
github-project-automation
bot
moved this from Team Review
to 👀 In review
in IDEasy board
|
|
||
| @Test | ||
| public void testRunUpdateSoftwareDoesNotFailWhenSettingPathIsDeleted() { | ||
| public void testRunUpdateSoftwareDoesNotFailWhenSettingPathIsDeleted(WireMockRuntimeInfo wireMockRuntimeInfo) { |
There was a problem hiding this comment.
Please add Javadoc with params and why this test is needed.
There was a problem hiding this comment.
doesn't the method signature already tell enough?
You can also remove the plublic keyword and Intellij linter will stop complaining about missing JavaDoc.
Just my 2 cents for KISS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1521.
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal