Fix IDEasy complete double-matching issue by preventing duplicate candidates

[Copilot]

Problem

IDEasy complete was matching commandlets twice during the completion process, potentially causing duplicate completion candidates to be shown to users. This happened because:

1. CommandletFinder.findNext() calls property.apply() which adds completion candidates during the commandlet finding phase
2. AbstractIdeContext.complete() then calls completeCommandlet() which may add the same candidates again

Solution

Added duplicate prevention logic in CompletionCandidateCollectorDefault.add() to check if a candidate with the same text already exists before adding it. This prevents duplicate completion candidates from being added to the collector.

Changes Made

• Modified CompletionCandidateCollectorDefault.add() to check for existing candidates with the same text before adding new ones
• Added comprehensive tests to verify no duplicate candidates are returned:
  • CompletionDuplicateTest - general duplicate prevention testing
  • CompleteCommandletTest - specific test for the CompleteCommandlet
  • Issue536Test - test for the specific scenario mentioned in the issue (ide complete in)

Testing

• All existing completion tests pass (28 tests total)
• New tests verify no duplicates are produced for various completion scenarios
• Manual verification confirms the fix works correctly for the scenario ide complete in

Benefits

• Fixes the double-matching issue where completion candidates could appear multiple times
• Maintains backward compatibility with existing functionality
• Minimal performance impact - only adds a simple duplicate check
• Clean and surgical fix that doesn't change core commandlet finding or completion logic

The fix ensures that users see clean, duplicate-free completion suggestions when using IDEasy's auto-completion feature.

Fixes #536.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• mobeigi.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.10/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.10/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.10 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.10/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/IDEasy/IDEasy org.codehaus.plexus.classworlds.launcher.Launcher clean compile test-compile (dns block)
• www.github.com
  • Triggering command: /usr/lib/jvm/java-21-openjdk-amd64/bin/java -javaagent:/home/REDACTED/.m2/repository/org/jacoco/org.jacoco.agent/0.8.13/org.jacoco.agent-0.8.13-runtime.jar=destfile=/home/REDACTED/work/IDEasy/IDEasy/cli/target/jacoco.exec -jar /home/REDACTED/work/IDEasy/IDEasy/cli/target/surefire/surefirebooter-20250715130859707_3.jar /home/REDACTED/work/IDEasy/IDEasy/cli/target/surefire 2025-07-15T13-08-59_595-jvmRun1 surefire-20250715130859707_1tmp surefire_0-20250715130859707_2tmp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coveralls]

Pull Request Test Coverage Report for Build 16294769564

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.07%) to 68.52%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	78.69%
com/devonfw/tools/ide/completion/CompletionCandidateCollectorDefault.java	2	88.46%

Totals
Change from base Build 16117325700:	0.07%
Covered Lines:	8419
Relevant Lines:	11884

---

💛 - Coveralls

[Copilot]

Pull Request Overview

This PR prevents duplicate completion candidates by checking for existing texts before adding new ones and adds tests to verify no duplicates across various scenarios.

• Added duplicate check in CompletionCandidateCollectorDefault.add() to skip candidates with existing text
• Introduced new tests (CompletionDuplicateTest, CompleteCommandletTest, Issue536Test) to ensure no duplicate suggestions are produced

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
cli/src/main/java/com/devonfw/tools/ide/completion/CompletionCandidateCollectorDefault.java	Added loop to detect existing candidate text and return early
cli/src/test/java/com/devonfw/tools/ide/completion/CompletionDuplicateTest.java	New test covering multiple input prefixes to confirm no duplicates
cli/src/test/java/com/devonfw/tools/ide/commandlet/CompleteCommandletTest.java	New test verifying CompleteCommandlet output has no repeated lines
cli/src/test/java/com/devonfw/tools/ide/completion/Issue536Test.java	New test for the specific ide complete in scenario

Comments suppressed due to low confidence (1)

cli/src/main/java/com/devonfw/tools/ide/completion/CompletionCandidateCollectorDefault.java:38

• Add a unit test that tries to add two candidates with the same text but different description or property to verify the duplicate prevention logic works as intended.

    // Check if this candidate already exists to avoid duplicates

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• mobeigi.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.10/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.10/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.10 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.10/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/IDEasy/IDEasy org.codehaus.plexus.classworlds.launcher.Launcher clean compile test-compile -Dtest=CompleteCommandletTest (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list