fileaccess delete symlink fix #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting a symlink resulted in an exception due to the call to deleteRecursive. This call was removed in the case of a symlink.
|
looks good to me. |
hohwille
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
@MattesMrzik Thanks for finding and fixing this bug 👍
I already reviewed it as part of your other PR. However, as you created this PR, I can already approve and merge this.
hohwille
added
the
story-review
hohwille
added
the
story-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a symlink resulted in an exception due to the call to deleteRecursive. This call was removed in the case of a symlink.