#103: create java resemblance for security.json #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14172089567Details
💛 - Coveralls |
|
Please add the ticket ID to your commits, so they are properly linked to the issue later. |
cli/src/main/java/com/devonfw/tools/ide/url/model/folder/UrlEdition.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/UrlSecurityFile.java
Show resolved
Hide resolved
hohwille
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
@KianRolf thanks for your PR. You did a great job and perfectly understood the task to implement here. Nice that you even added the ability to have security.json for all editions of a tool 👍
I left some review comments for further improvements.
Please have a look and once resolved we merge this PR.
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/CVE.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/ToolSecurity.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/ToolSecurity.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/ToolSecurity.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 28, 2025
cli/src/main/java/com/devonfw/tools/ide/tool/repository/ToolRepository.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 28, 2025
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/ToolSecurity.java
Outdated
Show resolved
Hide resolved
…olSecurity.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…olSecurity.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…olSecurity.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…olSecurity.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
hohwille
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
@KianRolf thanks for the rework. Now everything is perfect and ready to merge. 👍
To speed this up, I also resolved review comments from @jan-vcapgemini that I could confirm to be addressed properly now (JavaDoc consistency).
So I will merge this now.
hohwille
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparatory work #103
Gives the security.json files a representation in java analog to the dependency.json files