-
Notifications
You must be signed in to change notification settings - Fork 45
#1008: improve upgrade settings #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1008: improve upgrade settings #1146
Conversation
…ttps://github.com/leonrohne27/IDEasy into fix/1130-improve-behaviour-on-ambigous-xpath-match
Pull Request Test Coverage Report for Build 14191464584Details
💛 - Coveralls |
|
In case you wonder, I messed up with the branches, but it should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonrohne27 thanks for your PR.
The actual updating of the properties file looks already good to me. 👍
However, the way you try to find the properties is not correct.
It is required that you first read and understand the documentation of the related feature:
https://github.com/devonfw/IDEasy/blob/main/documentation/repository.adoc
p.s.: I took a shortcut even though this PR was in team review state to speed up our progress.
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
…ingsCommandlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…ingsCommandlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…ingsCommandlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonrohne27 thanks for your rework. I resolved all existing review comments 👍
Looking at the PR again I found a small problem that I solved with a constructive suggestion.
If you agree and commit it, we can merge this. Thanks.
cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java
Outdated
Show resolved
Hide resolved
|
I have successfully tested this but found and file this issue #1214 |
Fixes: #1008
Implemets: