Skip to content

Conversation

@leonrohne27
Copy link
Contributor

Fixes: #1008

Implemets:

  • In properties, "git-url" und "git.url" are replaced with "git_url"
  • In properties, "eclipse=import" is replaced with "import=eclipse"

@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2025

Pull Request Test Coverage Report for Build 14191464584

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 67.768%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java 21 76.5%
Totals Coverage Status
Change from base Build 14190953598: 0.01%
Covered Lines: 7907
Relevant Lines: 11238

💛 - Coveralls

@leonrohne27
Copy link
Contributor Author

leonrohne27 commented Mar 19, 2025

In case you wonder, I messed up with the branches, but it should be fine now.
To implement this story, I used filewalkers, which I know you removed in the other code sections.
I tried it otherwise but I was not able to fix it. Now it works, but you have to decide whether you want this kind of implementation or not.

@leonrohne27 leonrohne27 self-assigned this Mar 19, 2025
@leonrohne27 leonrohne27 moved this from 🆕 New to Team Review in IDEasy board Mar 19, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonrohne27 thanks for your PR.
The actual updating of the properties file looks already good to me. 👍
However, the way you try to find the properties is not correct.

It is required that you first read and understand the documentation of the related feature:
https://github.com/devonfw/IDEasy/blob/main/documentation/repository.adoc

p.s.: I took a shortcut even though this PR was in team review state to speed up our progress.

@hohwille hohwille changed the title Fix/1008 improve upgrade settings #1008: improve upgrade settings Mar 20, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonrohne27 thanks for your rework. I resolved all existing review comments 👍

Looking at the PR again I found a small problem that I solved with a constructive suggestion.
If you agree and commit it, we can merge this. Thanks.

@hohwille hohwille merged commit d8e1902 into devonfw:main Apr 1, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Team Review to ✅ Done in IDEasy board Apr 1, 2025
@hohwille hohwille added this to the release:2025.04.001 milestone Apr 1, 2025
@hohwille hohwille self-assigned this Apr 1, 2025
@hohwille
Copy link
Member

hohwille commented Apr 8, 2025

I have successfully tested this but found and file this issue #1214

@hohwille hohwille added upgrade-settings enhancement New feature or request repository Commandlet to clone, build or import git repositories settings ide-settings repo and replated processes and features labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request repository Commandlet to clone, build or import git repositories settings ide-settings repo and replated processes and features upgrade-settings

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Improve upgrade-settings to cleanup legacy configs in repositories

5 participants