-
Couldn't load subscription status.
- Fork 45
Description
From PR #250 we have to following review improvements left to do:
- remove
TomcatCommandand makeTomcatcommandlet to simply delegate tocatalina.shpassing any given arguments fromide tomcat «args»
- extract
UrlDependencyFilefor URL-Model to support lazy loading and simpler access todependency.json - create PR for
ide-urlsto adddependencies.jsontotomcat/tomcat. - extract
withEnvVarmethod fromProcessContextto own interfaceEnvironmentContext. - introduce new method to
LocalToolCommandletfor setting environment variablespublic void setEnvironment(EnvironmentContext context, Path toolPath). - refactor
installInRepoinstallToolmethod so we can passVersionRage(instead ofVersionIdentifier) for a dependency (from theDependencyInfo). - when trying to resolve the dependency version and install the tool, first check if the resolved version of the configured tool version of the tool matches the dependency version range. If that is the case then use the tool installation preferred by the project (
software/«tool»viagetToolPath()). Only if that version does not match then install an additional version in repo if not already available. - If you install the tool version in the repo, try to reuse the existing code from
installInRepomethods. - In
runToolwe can then first create the process context, pass it asEnvironmentContextto the installation method (needs some refactoring) so that there is only one single place in the code getting the dependencies and looping over them that does all together. That is the dependent tools are all installed and also their environment variables are set. For regular existing methods likeinstall()andinstall(boolean)you could passnullasEnvironmentContextand in case that isnullalso omit to call thesetEnvironment(EnvironmentContext, Path)method.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Type
Projects
Status
✅ Done