#3: implement component rules C3-C7#29
Merged
hohwille merged 26 commits intodevonfw-sample:masterfrom Mar 21, 2023
Merged
Conversation
Business architecture definition of dependencies test.
Components service layers should not depend on each other.
NOT READY!
…llen/archunit into add-component-rules
Added a more concise error message.
Deleted C2 rule since it is obsolete. It will be covered by devonfw-sample#21. Refactoring by automatic code-formatting of devonfw-ide.
Minor refactoring. Changed ArchCondition to final. Renamed boolean dependencyAllowed to isAllowedDependency.
Add component rules C5-C7
HOTFIX general component use. Co-Authored-By: NicolasVanBellen <74297820+NicolasVanBellen@users.noreply.github.com>
vlad961
changed the title
@NicolasVanBellen Adjusted component rules C3-C7 to use the newly introduced PackageStructure type. Co-Authored-By: NicolasVanBellen <74297820+NicolasVanBellen@users.noreply.github.com>
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 14, 2023
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
Closed
1 task
Updated PackageStructure.java: - Added a projects architecture DEFAULT_COMPONENT field. - Added a isComponentGeneral() getter. Updated ComponentRuleTest.java: - Reimplemented C3 and C6 using a custom ArchCondition + PackageStructure - Resolved all review annotation of @hohwille Co-Authored-By: NicolasVanBellen <74297820+NicolasVanBellen@users.noreply.github.com>
hohwille
reviewed
Mar 20, 2023
Contributor
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
Now, I understand - I did already add all the review comments but they did not become visible because I did not finish the review.... So here are my recent comments.
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/ComponentRuleTest.java
Outdated
Show resolved
Hide resolved
Reworked component rules according to recent review. - added DescribedPredicates - added composeViolationMessage method - added test for general component
hohwille
approved these changes
Mar 21, 2023
Contributor
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@vlad961 Wow. You perfectly nailed it and even addressed all my nice to have comments and perfectly implemented my idea for improvement. The rules now are beautiful to read. 👍
Ready to merge. When implementing #19 we can still avoid some more redundancy and make this nice work available to all other rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3
Implemented Component rules C3 and C4 with Archunit.