Open
Conversation
|
Mykhailo Novitskyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
klaudia-nowak
approved these changes
Aug 18, 2023
Collaborator
|
Collaborator
Author
|
|
KMariusz
reviewed
Sep 14, 2023
| @@ -0,0 +1,44 @@ | |||
| package com.capgemini.mrchecker.playwright.core.newDrivers; | |||
|
|
|||
|
|
|||
Collaborator
There was a problem hiding this comment.
Double newline, please use formatter
KMariusz
reviewed
Sep 14, 2023
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Tag("UnitTest") | ||
| public @interface UnitTest { | ||
| } No newline at end of file |
KMariusz
reviewed
Sep 14, 2023
| @@ -1,5 +1,5 @@ | |||
| playwright.browser.proxy= | |||
| playwright.browser.channel= | |||
| #playwright.browser.proxy= | |||
Collaborator
There was a problem hiding this comment.
Do we need this change? Are tests fail if you leave it assigned empty?
KMariusz
reviewed
Sep 14, 2023
| assertEquals("chromium", driverName, "Wrong browser name"); | ||
| } | ||
|
|
||
| } No newline at end of file |
KMariusz
reviewed
Sep 14, 2023
|
|
||
| assertThat(toStringValue, is(equalTo("browser=" + STARTUP_PARAMETERS_VALUES.get("browser")))); | ||
| } | ||
| } No newline at end of file |
KMariusz
reviewed
Sep 14, 2023
| @@ -0,0 +1 @@ | |||
| allure.results.directory=target/allure-results No newline at end of file | |||
KMariusz
reviewed
Sep 14, 2023
| junit.jupiter.execution.parallel.config.strategy=dynamic | ||
| junit.jupiter.execution.parallel.config.dynamic.factor=1 | ||
| cucumber.ansi-colors.disabled=false | ||
| cucumber.publish.quiet=true No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.