feat: 실시간 경매장 정보 fetcher and sheduler 및 거대한 외침의 뿔피리 엘라스틱 서치 구현 by dev-ant · Pull Request #91 · devnogi/open-api-batch-server

dev-ant · 2026-01-28T14:45:46Z

📋 상세 설명

📊 체크리스트

PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
코드가 테스트 되었나요 pass
문서는 업데이트 되었나요
불필요한 코드를 제거했나요
이슈와 라벨이 등록되었나요 이슈만 등록

📆 마감일

github-actions · 2026-01-28T14:46:57Z

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

Copilot

Pull request overview

This PR implements real-time auction data fetching/scheduling and Elasticsearch integration for Horn Bugle search functionality in the Mabinogi Open API batch server.

Changes:

Adds real-time auction data collection with 10-minute interval scheduling and duplicate detection logic
Implements Elasticsearch integration with Korean full-text search (Ngram parser) for Horn Bugle history
Refactors auction table structure, separating history (auction_history_item_option) from realtime (auction_realtime_item, auction_realtime_item_option)

Reviewed changes

Copilot reviewed 157 out of 158 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
V15__refactor_auction_tables_for_realtime_history_separation.sql	Database migration to separate auction history and realtime tables
V16__update_unknown_item_name_and_segong_option_level.sql	Updates unknown item names and parses segong option levels
V17__add_fulltext_index_to_horn_bugle_world_history.sql	Adds MySQL FULLTEXT index for Horn Bugle search
HornBugleIndexService.java	Elasticsearch indexing service for Horn Bugle data
AuctionRealtimeScheduler.java	Scheduler for real-time auction data collection (10-minute intervals)
AuctionRealtimeFetcher.java	Fetcher with cursor-based pagination and duplicate detection
HornBugleService.java	Updated to support both Elasticsearch and MySQL FULLTEXT search
docker-compose-*.yml	Docker configurations updated with Elasticsearch services
build.gradle.kts	Added Elasticsearch dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T14:50:35Z

docker-compose-dev.yml

        -Xmx${JAVA_OPTS_XMX:-512m}
        -XX:MaxMetaspaceSize=${JAVA_OPTS_MAX_METASPACE_SIZE:-150m}
        -XX:ReservedCodeCacheSize=${JAVA_OPTS_RESERVED_CODE_CACHE_SIZE:-48m}
+        -XX:ReservedCodeCacheSize=${JAVA_OPTS_RESERVED_CODE_CACHE_SIZE:-48m}


Duplicate line: -XX:ReservedCodeCacheSize=${JAVA_OPTS_RESERVED_CODE_CACHE_SIZE:-48m} appears on both line 59 and line 60. Remove the duplicate.

Suggested change

-XX:ReservedCodeCacheSize=${JAVA_OPTS_RESERVED_CODE_CACHE_SIZE:-48m}

Copilot · 2026-01-28T14:50:35Z

...main/java/until/the/eternity/auctionrealtime/domain/mapper/OpenApiAuctionRealtimeMapper.java

+    @AfterMapping
+    default void afterMapping(
+            OpenApiAuctionRealtimeResponse dto, @MappingTarget AuctionRealtimeItem entity) {
+        // item_name이 "(Unknown)"인 경우 item_display_name으로 대체
+        if (UNKNOWN_ITEM_NAME.equals(entity.getItemName())) {
+            entity.setItemName(dto.itemDisplayName());
+        }
+    }


The mapper is using @AfterMapping to replace "(Unknown)" item names with display names. However, this logic exists in both OpenApiAuctionHistoryMapper and OpenApiAuctionRealtimeMapper with identical implementation. Consider extracting this to a shared helper method or abstract mapper to follow DRY principles.

Copilot · 2026-01-28T14:50:36Z

...n/java/until/the/eternity/auctionrealtime/domain/mapper/OpenApiRealtimeItemOptionMapper.java

+
+    @AfterMapping
+    default void afterMapping(
+            OpenApiAuctionItemOptionResponse dto, @MappingTarget AuctionRealtimeItemOption entity) {
+        // option_type이 "세공 옵션"인 경우에만 파싱 수행
+        if (!SEGONG_OPTION_TYPE.equals(entity.getOptionType()) || entity.getOptionValue() == null) {
+            return;
+        }
+
+        String originalValue = entity.getOptionValue();
+
+        // 패턴 1: "스킬명 숫자 레벨" 또는 "스킬명 숫자레벨" 형식
+        Matcher matcher1 = PATTERN_LEVEL_SUFFIX.matcher(originalValue);
+        if (matcher1.matches()) {
+            entity.setOptionValue(matcher1.group(1));
+            entity.setOptionValue2(matcher1.group(3));
+            entity.setOptionDesc(matcher1.group(2));
+            return;
+        }
+
+        // 패턴 2: "스킬명(숫자레벨:효과)" 형식
+        Matcher matcher2 = PATTERN_LEVEL_PARENTHESIS.matcher(originalValue);
+        if (matcher2.matches()) {
+            entity.setOptionValue(matcher2.group(1));
+            entity.setOptionValue2(matcher2.group(3));
+            entity.setOptionDesc(matcher2.group(2));
+        }
+        // 두 패턴 모두 매칭되지 않으면 원본 값 유지


The segong option parsing logic using regex patterns is duplicated across OpenApiItemOptionMapper and OpenApiRealtimeItemOptionMapper. Both mappers have identical Pattern constants (PATTERN_LEVEL_SUFFIX, PATTERN_LEVEL_PARENTHESIS) and afterMapping logic. Consider extracting this common parsing logic to a shared utility class to improve maintainability and avoid duplication.

Copilot · 2026-01-28T14:50:36Z

src/main/java/until/the/eternity/auctionhistory/domain/entity/AuctionHistory.java


    @OneToMany(mappedBy = "auctionHistory", cascade = CascadeType.ALL, orphanRemoval = true)
-    private List<AuctionItemOption> auctionItemOptions;
+    private List<AuctionHistoryItemOption> auctionHistoryItemOptions;


getAuctionHistoryItemOptions exposes the internal representation stored in field auctionHistoryItemOptions. The value may be modified after this call to getAuctionHistoryItemOptions.
getAuctionHistoryItemOptions exposes the internal representation stored in field auctionHistoryItemOptions. The value may be modified after this call to getAuctionHistoryItemOptions.

Copilot · 2026-01-28T14:50:36Z

src/main/java/until/the/eternity/auctionitem/domain/entity/AuctionRealtimeItem.java

+    private String itemTopCategory;
+
+    @OneToMany(mappedBy = "auctionRealtimeItem", cascade = CascadeType.ALL, orphanRemoval = true)
+    private List<AuctionRealtimeItemOption> auctionRealtimeItemOptions;


getAuctionRealtimeItemOptions exposes the internal representation stored in field auctionRealtimeItemOptions. The value may be modified after this call to getAuctionRealtimeItemOptions.
getAuctionRealtimeItemOptions exposes the internal representation stored in field auctionRealtimeItemOptions. The value may be modified after this call to getAuctionRealtimeItemOptions.

Copilot · 2026-01-28T14:50:37Z

src/main/java/until/the/eternity/auctionitem/domain/entity/AuctionRealtimeItemOption.java

+@Getter
+@NoArgsConstructor
+@AllArgsConstructor
+@Builder


Default toString(): AuctionRealtimeItem inherits toString() from Object, and so is not suitable for printing.

codecov · 2026-01-28T15:05:02Z

Codecov Report

❌ Patch coverage is 11.65354% with 561 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...persistence/AuctionRealtimeQueryDslRepository.java	0.00%	224 Missing ⚠️
...structure/elasticsearch/HornBugleIndexService.java	0.00%	66 Missing ⚠️
...pplication/scheduler/AuctionRealtimeScheduler.java	0.00%	63 Missing ⚠️
...ornBugle/application/service/HornBugleService.java	0.00%	31 Missing ⚠️
...me/application/service/AuctionRealtimeService.java	0.00%	28 Missing ⚠️
...Bugle/application/runner/HornBugleIndexRunner.java	0.00%	27 Missing ⚠️
...e/infrastructure/client/AuctionRealtimeClient.java	4.76%	20 Missing ⚠️
...istence/AuctionRealtimeItemRepositoryPortImpl.java	0.00%	18 Missing ⚠️
...history/domain/mapper/OpenApiItemOptionMapper.java	0.00%	17 Missing ⚠️
...domain/mapper/OpenApiRealtimeItemOptionMapper.java	0.00%	17 Missing ⚠️
... and 11 more

📢 Thoughts on this report? Let us know!

dev-ant added 6 commits January 26, 2026 21:58

feat: auction realtime flyway script 및 스케쥴러 구현

0ed2300

feat: item_option 세공 옵션 파싱 로직 추가

372b501

feat: horn bugle eleastic search 구현

c5381d6

feat: auction realtime api permitall 설정

5ff52ae

docs: README 업데이트

b49f803

infra: docker-compose-prod에 elastic search 추가

4ca2732

dev-ant requested a review from Copilot January 28, 2026 14:45

dev-ant self-assigned this Jan 28, 2026

dev-ant added the ✨feature 새로운 기능 추가 label Jan 28, 2026

Copilot started reviewing on behalf of dev-ant January 28, 2026 14:46 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

dev-ant added 2 commits January 29, 2026 00:01

fix: optimize imports

8050a30

fix: hornbugle test 코드 제거

d0c9228

dev-ant merged commit adb87a1 into dev Jan 28, 2026
1 of 2 checks passed

dev-ant deleted the feat/auction-realtime-sheduler branch January 28, 2026 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 실시간 경매장 정보 fetcher and sheduler 및 거대한 외침의 뿔피리 엘라스틱 서치 구현#91

feat: 실시간 경매장 정보 fetcher and sheduler 및 거대한 외침의 뿔피리 엘라스틱 서치 구현#91
dev-ant merged 8 commits intodevfrom
feat/auction-realtime-sheduler

dev-ant commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dev-ant commented Jan 28, 2026

📋 상세 설명

📊 체크리스트

📆 마감일

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ 테스트 결과 for PR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 28, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Jan 28, 2026 •

edited

Loading