Skip to content

feat: 아이템 카테고리 정보 REST API 구현#49

Merged
dev-ant merged 2 commits intodevfrom
feat/item-category-api
Sep 11, 2025
Merged

feat: 아이템 카테고리 정보 REST API 구현#49
dev-ant merged 2 commits intodevfrom
feat/item-category-api

Conversation

@dev-ant
Copy link
Contributor

@dev-ant dev-ant commented Sep 11, 2025

📋 상세 설명

  • 아이템 상위 카테고리, 하위 카테고리 데이터를 반환하는 API 구현
    • ItemCategory는 개수가 적고, 변동도 적어 DB가 아닌 Enum으로 관리.

📊 체크리스트

  • PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
  • 코드가 테스트 되었나요
  • 문서는 업데이트 되었나요
  • 불필요한 코드를 제거했나요
  • 이슈와 라벨이 등록되었나요

📆 마감일

Close #48

@dev-ant dev-ant requested a review from Copilot September 11, 2025 15:02
@dev-ant dev-ant self-assigned this Sep 11, 2025
@dev-ant dev-ant added the ✨feature 새로운 기능 추가 label Sep 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a REST API for retrieving item category information, including top-level and sub-category data. The implementation uses enums to manage ItemCategory data instead of database storage due to the small and infrequently changing dataset.

Key changes:

  • Added ItemCategoryResponse DTO to structure category data
  • Created ItemController with /api/items/categories endpoint
  • Implemented ItemService to handle category retrieval logic

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/java/until/the/eternity/item/interfaces/rest/dto/ItemCategoryResponse.java New DTO for category response structure with static factory method
src/main/java/until/the/eternity/item/interfaces/rest/controller/ItemController.java New REST controller providing category information endpoint
src/main/java/until/the/eternity/item/application/service/ItemService.java New service layer for item-related operations
src/main/java/until/the/eternity/itemoption/domain/entity/ItemOption.java Minor comment formatting cleanup
src/test/java/until/the/eternity/auctionhistory/application/service/persister/AuctionHistoryPersisterTest.java Import statement reorganization
src/test/java/until/the/eternity/auctionhistory/application/service/fetcher/AuctionHistoryFetcherTest.java Import statement reorganization
src/test/java/until/the/eternity/auctionhistory/application/service/AuctionHistoryServiceTest.java Import statement reorganization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

.subCategory(itemCategory.getSubCategory())
.topCategory(itemCategory.getTopCategory())
.build())
.collect(Collectors.toList());
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using .toList() instead of .collect(Collectors.toList()) for better performance and readability in Java 16+.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tem/interfaces/rest/controller/ItemController.java 0.00% 2 Missing ⚠️
...eternity/item/application/service/ItemService.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dev-ant dev-ant merged commit 6ad6072 into dev Sep 11, 2025
1 of 2 checks passed
@dev-ant dev-ant deleted the feat/item-category-api branch September 11, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feature 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

아이템 카테고리 정보 REST API 구현

1 participant