fix: Bulk Insert를 위해 Auction History, Auction Item Option ID 생성 전략을 변경한다#47
Merged
fix: Bulk Insert를 위해 Auction History, Auction Item Option ID 생성 전략을 변경한다#47
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the ID generation strategy for Auction History and Auction Item Option entities to enable bulk insert operations and improve memory efficiency. The main changes include switching from IDENTITY to using auction_buy_id as the primary key for auction history, and replacing numeric IDs with UUID for item options.
- Converts auction_history primary key from auto-generated IDENTITY to use auction_buy_id from Open API
- Changes auction_item_option to use UUID-based primary key instead of IDENTITY
- Implements proper bulk insert with batch processing for better performance
Reviewed Changes
Copilot reviewed 41 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| V4__change_auction_history_pk.sql | Database migration to change auction_history primary key to auction_buy_id |
| V5__change_item_option_pk.sql | Database migration to replace item option ID with UUID primary key |
| V6__change_item_option_column_name.sql | Renames item_option_id column to id for consistency |
| AuctionHistory.java | Updates entity to use auction_buy_id as primary key |
| ItemOption.java | Adds UUID generation and updates foreign key mapping |
| AuctionHistoryRepositoryPortImpl.java | Implements proper bulk insert with batch processing |
| Various test files | Updates test methods to use String IDs instead of Long |
| Various service files | Import statement reorganization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/until/the/eternity/itemoption/domain/entity/ItemOption.java
Outdated
Show resolved
Hide resolved
src/main/java/until/the/eternity/itemoption/domain/entity/ItemOption.java
Show resolved
Hide resolved
src/main/java/until/the/eternity/auctionhistory/domain/entity/AuctionHistory.java
Show resolved
Hide resolved
✅ 테스트 결과 for PRBuild: success 🧪 테스트 실행 with Gradle |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 상세 설명
📊 체크리스트
📆 마감일