fix: OPEN API WebClient으로 인한 Thread Starvation 문제를 해결한다#44
Merged
Conversation
✅ 테스트 결과 for PRBuild: success 🧪 테스트 실행 with Gradle |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a thread starvation issue caused by the WebClient implementation in the OpenAPI auction history fetcher by restructuring the data fetching and persistence logic.
- Refactored the
AuctionHistoryClientto return reactiveMonoobjects instead of blocking synchronously - Restructured the scheduler to fetch all data first, then batch save to reduce database transactions
- Temporarily commented out test files for auction history fetcher and service components
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AuctionHistoryClient.java | Changed to return Mono and removed blocking calls |
| AuctionHistoryScheduler.java | Restructured to collect all entities before batch saving and removed inter-request delays |
| AuctionHistoryFetcher.java | Updated to work with reactive client and improved logging |
| AuctionHistoryPersister.java | Changed from saving directly to filtering and returning entities |
| AuctionHistoryService.java | Simplified to handle batch saving of entities |
| Various test files | Commented out test methods to disable them temporarily |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ava/until/the/eternity/auctionhistory/application/service/fetcher/AuctionHistoryFetcher.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 상세 설명
📊 체크리스트
📆 마감일