backend/keyboard: accept non-ascii characters #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should I also remove the match cases for |
devmobasa
reviewed
Dec 30, 2025
| Key::Unknown | ||
| } | ||
| } | ||
| _ => keysym.key_char().map_or(Key::Unknown, Key::Char), |
Owner
There was a problem hiding this comment.
Enter/Tab will insert control characters this way? Might need to add explicit handling for them?
Might need the Keysym::Return | Keysym::KP_Enter => Key::Return and Keysym::Tab | Keysym::KP_Tab => Key::Tab
Contributor
Author
There was a problem hiding this comment.
updated and added the rest of functions key and removed match case for 0
Owner
I think those are covered by Thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rn only ascii characters are accepted, and others return
Key::Unknown. This removes the check and usesKeysym::key_char()to obtain the character.Also remvoed match cases for
t, e, r, g, b, y, o, p, w, k, zaskey_char()already handles them, unless if I'm missing something.I've only tested with Arabic, but I'd assume it will for other layouts
