Repository navigation
Minor enhancement to avoid null exceptions. #1533
Description
Activity
Hi @kzu I'm interested in working on this issue. Can I take it? Also, could you provide any additional details if needed?
Hi @ndwpatrick. Help is very much appreciated!
Reacted by Pratik Nandanwar@kzu Can you please assign this issue to me so that I can start working on it.
Done!
Hi @ndwpatrick , are you working on this issue?
Can I maybe take over?Hi @kzu , it seems this issue is not being worked on.
Could I take over?Sure thing! Assigning to you
Reacted by Shir Avneri- locked and limited conversation to collaborators
on Jun 26, 2025
Discussed in https://github.com/devlooped/moq/discussions/1529
Originally posted by iPazooki February 6, 2025
In the AwaitableFactory.cs file, the
TryGetmethod may returnnull, which is not considered good practice. To address this issue and prevent potential null reference exceptions, I recommend changing the return type toIAwaitableFactory?. This indicates that the return value can be nullable, alerting developers that they need to handle this scenario appropriately. Subsequently, we need to change five more places because of this change which is not a big deal.