Minor CallToAction cleanup #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kzu
commented
Jul 9, 2025
kzu
commented
- SendXXX is used when there isn't a clear verb we can use. In this case, CallToAction is already a verb/action so we don't need the Send prefix (just like Reply/React).
- Calls to action can (for now?) never be a reply to anything, they are standalone messages. Remove the Context everywhere therefore, since we don't use it at all anyway in the actual sending implementation.
- Unify naming on Action for the button text.
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.18 with 💜 by @devlooped |
- SendXXX is used when there isn't a clear verb we can use. In this case, CallToAction is already a verb/action so we don't need the Send prefix (just like Reply/React). - Calls to action can (for now?) never be a reply to anything, they are standalone messages. Remove the Context everywhere therefore, since we don't use it at all anyway in the actual sending implementation. - Unify naming on Action for the button text.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CallToAction API to improve naming consistency and remove unused context functionality. The changes align the CallToAction naming pattern with other message types like Reply/React that don't use a "Send" prefix, and simplify the API by removing context parameters that aren't utilized.
- Renamed
SendCallToActionAsynctoCallToActionAsyncto follow consistent naming patterns - Unified parameter naming from
buttonTexttoactionacross all CallToAction methods - Removed unused
Contextparameter from CallToActionResponse constructors and method calls
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WhatsAppClientExtensions.cs | Updates method name and parameter naming for CallToAction extension method |
| MessageExtensions.cs | Removes context parameter from CallToActionResponse constructor calls and adds documentation |
| CallToActionResponse.cs | Refactors record definition to remove context parameter and unify action parameter naming |
| /// <param name="Text">The content of the message calling to action.</param> | ||
| /// <param name="Action">The action button text.</param> | ||
| /// <param name="Url">The URL to navigate to when the action button is clicked.</param> | ||
| /// /// <param name="ConversationId">The conversation id where this response was generated</param> |
There was a problem hiding this comment.
There are extra forward slashes in the XML documentation comment. It should be '/// ...' instead of '/// /// ...'
Suggested change
| /// /// <param name="ConversationId">The conversation id where this response was generated</param> | |
| /// <param name="ConversationId">The conversation id where this response was generated</param> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.