Added support for call to action responses #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.18 with 💜 by @devlooped |
There was a problem hiding this comment.
Pull Request Overview
Adds support for sending interactive call-to-action (CTA) URL messages and related response handling across the WhatsApp client API and message abstractions.
- Introduces a new
SendCallToActionAsyncextension onIWhatsAppClientwith XML docs. - Adds
CallToActionhelper inMessageExtensionsand aCallToActionResponserecord with JSON polymorphic mapping. - Provides an integration test for CTA payloads in
WhatsAppClientTests.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/WhatsApp/WhatsAppClientExtensions.cs | New SendCallToActionAsync method and XML comments |
| src/WhatsApp/MessageExtensions.cs | Added CallToAction extension returning CallToActionResponse |
| src/WhatsApp/IMessage.cs | Registered CallToActionResponse for JSON deserialization |
| src/WhatsApp/CallToActionResponse.cs | Introduced CallToActionResponse record |
| src/Tests/WhatsAppClientTests.cs | Added SendsCallToActionAsync integration test |
Comments suppressed due to low confidence (3)
src/WhatsApp/WhatsAppClientExtensions.cs:560
- The
urlparameter is missing an<param>XML doc entry. Please add<param name="url">The URL the CTA button should open.</param>above the method.
public static Task<string?> SendCallToActionAsync(this IWhatsAppClient client, string serviceId, string userNumber, string message, string buttonText, string url, CancellationToken cancellation = default)
src/Tests/WhatsAppClientTests.cs:107
- [nitpick] The comment mentions "three buttons" but this CTA payload only includes a single URL button. Update the comment to accurately reflect the one-button CTA scenario.
// Send an interactive message with three buttons showcasing the payload/value
src/WhatsApp/WhatsAppClientExtensions.cs:560
- There are no unit tests covering
SendCallToActionAsync. Consider adding tests to verify that it constructs the correct payload and handles cancellation or error scenarios.
public static Task<string?> SendCallToActionAsync(this IWhatsAppClient client, string serviceId, string userNumber, string message, string buttonText, string url, CancellationToken cancellation = default)
kzu
reviewed
Jul 9, 2025
src/WhatsApp/MessageExtensions.cs
Outdated
| /// <summary> | ||
| /// Sends an interactive call to action response to the user message. | ||
| /// </summary> | ||
| public static CallToActionResponse CallToAction(this IMessage message, string text, string buttonText, string url) |
Member
There was a problem hiding this comment.
[nitpick]
buttonText > action
add bool isReply = false to make it a reply (Context == message.Id) or leave it null
Collaborator
Author
There was a problem hiding this comment.
partially fixed with the action renaming for now. I'm not sure about the other one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.