Skip to content

Add idempotency to both whatsapp functions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Apr 8, 2025
Merged

Add idempotency to both whatsapp functions #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/WhatsApp/AzureFunctions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ public async Task<HttpResponseMessage> Message([HttpTrigger(AuthorizationLevel.A

if (await WhatsApp.Message.DeserializeAsync(json) is { } message)
{
// Ensure idempotent processing
var table = tableClient.GetTableClient("whatsapp");
await table.CreateIfNotExistsAsync();
if (await table.GetEntityIfExistsAsync<TableEntity>(message.From.Number, message.Id) is { HasValue: true } existing)
{
logger.LogInformation("Skipping already handled message {Id}", message.Id);
return new HttpResponseMessage(System.Net.HttpStatusCode.OK);
}

// Otherwise, queue the new message
var queue = queueClient.GetQueueClient("whatsapp");
await queue.CreateIfNotExistsAsync();
await queue.SendMessageAsync(json);
Expand All @@ -78,7 +88,9 @@ public async Task Process([QueueTrigger("whatsapp", Connection = "AzureWebJobsSt

if (await WhatsApp.Message.DeserializeAsync(json) is { } message)
{
// Ensure idempotent processing
// Ensure idempotent processing at dequeue time, since we might have been called
// multiple times for the same message by WhatsApp (Message method) while processing was still
// happening (and therefore we didn't save the entity yet).
var table = tableClient.GetTableClient("whatsapp");
await table.CreateIfNotExistsAsync();
if (await table.GetEntityIfExistsAsync<TableEntity>(message.From.Number, message.Id) is { HasValue: true } existing)
Expand Down