Allow constants to request a root area different than Constants #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opens up other scenarios for specific constants we don't want behind a Constants propery (i.e ThisAssembly.Git, see #69). A small refactoring of the targets with a new PrepareConstants will also make it easier for extenders to run before we do our conversion to AdditionalFiles, to keep the extended items clean even when they need to run before/after certain targets.
kzu
force-pushed
the
dev/ConstantsRoot
branch
from
462d3ab to
5892aff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens up other scenarios for specific constants we don't want behind a Constants propery (i.e ThisAssembly.Git, see #69).
A small refactoring of the targets with a new PrepareConstants will also make it easier for extenders to run before we do our conversion to AdditionalFiles, to keep the extended items clean even when they need to run before/after certain targets.