Skip to content

Remove C#9 requirement/comment #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove C#9 requirement/comment #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ThisAssembly.AssemblyInfo/ThisAssembly.AssemblyInfo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<PropertyGroup>
<PackageId>ThisAssembly.AssemblyInfo</PackageId>
<Description>** C# 9.0 ONLY **
<Description>
This package generates a static `ThisAssembly.Info` class with public
constants exposing the following attribute values generated by default for SDK style projects:

Expand Down
2 changes: 1 addition & 1 deletion src/ThisAssembly.Constants/ThisAssembly.Constants.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<PropertyGroup>
<PackageId>ThisAssembly.Constants</PackageId>
<Description>** C# 9.0 ONLY **
<Description>
This package generates a static `ThisAssembly.Constants` class with public
constants for each Constant MSBuild item in the project.

Expand Down
2 changes: 1 addition & 1 deletion src/ThisAssembly.Metadata/ThisAssembly.Metadata.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<PropertyGroup>
<PackageId>ThisAssembly.Metadata</PackageId>
<Description>** C# 9.0 ONLY **
<Description>
This package generates a static `ThisAssembly.Metadata` class with public
constants exposing each `[System.Reflection.AssemblyMetadata(..)]` defined for the project,
such as when using .NET 5.0+ support for `AssemblyMetadata` MSBuild items.
Expand Down
8 changes: 0 additions & 8 deletions src/ThisAssembly.Prerequisites/ThisAssembly.Prerequisites.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<Error Text="ThisAssembly requires MSBuild 16.8+ or .NET SDK 5.0+."
Condition="$([System.Version]::Parse('16.8.0').CompareTo($([System.Version]::Parse($(MSBuildVersion))))) == 1" />

<!-- See https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/langversion-compiler-option -->
<Warning Code="THIS001"
Text="ThisAssembly uses Roslyn source generators, which are only supported in C# 9.0 or greater at the moment."
Condition="'$(Language)' != 'C#' OR
('$(LangVersion)' != 'preview' AND
'$(LangVersion)' != 'latest' AND
'$(LangVersion)' != 'latestMajor' AND
'$(LangVersion)' &lt; '9.0')" />
</Target>

</Project>
2 changes: 1 addition & 1 deletion src/ThisAssembly.Project/ThisAssembly.Project.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<PropertyGroup>
<PackageId>ThisAssembly.Project</PackageId>
<Description>** C# 9.0 ONLY **
<Description>
This package generates a static `ThisAssembly.Project` class with public
constants exposing project properties that have been opted into this mechanism by adding
them as `ProjectProperty` MSBuild items in project file, such as:
Expand Down
2 changes: 1 addition & 1 deletion src/ThisAssembly.Strings/ThisAssembly.Strings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<PropertyGroup>
<PackageId>ThisAssembly.Strings</PackageId>
<Description>** C# 9.0 ONLY **
<Description>
This package generates a static `ThisAssembly.Strings` class with public
constants exposing string resources in .resx files or methods with the right number of
parameters for strings that use formatting parameters.
Expand Down
2 changes: 1 addition & 1 deletion src/ThisAssembly/ThisAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<PropertyGroup>
<PackageId>ThisAssembly</PackageId>
<Description>Meta-package that includes all ThisAssembly.* packages. ** C# 9.0 ONLY **</Description>
<Description>Meta-package that includes all ThisAssembly.* packages. </Description>
</PropertyGroup>

<ItemGroup>
Expand Down