-
-
Notifications
You must be signed in to change notification settings - Fork 90
Description
I do not mean to start drama here, but since the official response from the project was that Shagkur RE'd an official SDK library, and did not copy any official SDK code directly, I figured I should let you know that this is objectively false. Official SDK headers were used as reference to create libogc.
GXRModeObj has its first field called viTVMode
. However, the individual GXRModeObj instances have a comment labeling it as viDisplayMode
.
This is odd for a field to be different between the comment and the implementation, but it does happen, if the field was renamed during development. So, then, why does the same exact set of specific naming quirks (viTVMode
in the struct, viDisplayMode
in the comment) appear in the official Nintendo SDK?
While the struct names might appear in patents, official documentation, or in debug symbols, comments from code in an #if 0
block should never appear.
This has been known to me for at least 6 years. I would be absolutely astonished if the libogc maintainers were unaware of it. Regardless of what you feel about the legality and infringement of GPL licenses, the official stance of the project fundamentally cannot be that Shagkur only RE'd an official SDK library, when it was clear that official SDK headers were used as reference as well.