Implement ACT, finalize FRD implementation, fix Mii struct#558
Implement ACT, finalize FRD implementation, fix Mii struct#558fincs merged 3 commits intodevkitPro:masterfrom
Conversation
ZeroSkill1
commented
Mar 6, 2025
- Implemented the entirety of the friends services commands, fixing incorrect ones and adding all the missing ones.
- Fix up the existing base Mii struct.
|
Looks good, though, could you give more context on why you added PACKED? |
|
The MiiData struct as it was before was too large. Furthermore, the bitfields weren't padded properly and thus caused extraneous padding bytes to be inserted in between the inner structs. The MiiData struct must be exactly 0x5C in size (and it wasn't before). Both friends and ACT assume this base struct to be exactly 0x5C in size. |
|
Some of the changes add PACKED to structures that only contain 8-bit members. Why is that? |
|
That must've been an oversight from when I was trying to fix up the incorrect alignments. I've removed CTR_PACKED from the inner structs that don't need it. |
|
While I'm at it, I'm also going to add the implementation for ACT services. |
|
Is this PR done? In any case, would you mind tidying up history a bit once you're done? Ideally there should be one commit per service. |
db43801 to
5474f40
Compare
5474f40 to
711d0ee
Compare
|
Yes, I've added everything I wanted to change. I've reorganized the commits so each change (Mii struct, FRD, ACT) is its own separate commit. |