Skip to content

Fix return type of C2D_Fade and C2D_SetTintMode#44

Merged
fincs merged 3 commits intodevkitPro:masterfrom
KonPet:patch-1
Apr 27, 2023
Merged

Fix return type of C2D_Fade and C2D_SetTintMode#44
fincs merged 3 commits intodevkitPro:masterfrom
KonPet:patch-1

Conversation

@KonPet
Copy link
Contributor

@KonPet KonPet commented Apr 27, 2023

Fix returning a bool from a void function

Fix returning a `bool` from a `void` function
@fincs
Copy link
Member

fincs commented Apr 27, 2023

Either remove the return value, or add return true; in the success case

@KonPet
Copy link
Contributor Author

KonPet commented Apr 27, 2023

How did this even compile in the first place though? I mean citro2d gets compiled with -Wall and -Werror. How did it not catch the fact that a bool is being returned from a void function? oreo639 also found out that removing -save-temps makes the compiler give you an error there (can verify that by the way). Does the -save-temps flag remove the -Wreturn-type flag?

@fincs
Copy link
Member

fincs commented Apr 27, 2023

I'm equally puzzled.

@fincs fincs merged commit f5c2ec7 into devkitPro:master Apr 27, 2023
@fincs fincs changed the title Fix typo Fix return type of C2D_Fade and C2D_SetTintMode Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants