Fix wordNum off by one when TextBuf entirely full#43
Merged
fincs merged 1 commit intodevkitPro:masterfrom Sep 14, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the last word of a text is longer than the remaining capacity of the C2D_TextBuf,
text->words==glyph->wordNocausing out of bounds access in the alloca'd arrays when drawing the glyphs of this word, resulting in crashes.This PR ensures the words member of the C2D_Text has the correct value, even when the while loop exits from its condition (no remaining capacity) instead of the break on line end/string end.