Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the code base have memoization and improve ESLint rules to enforce it #37 #53

Merged
merged 16 commits into from
Jan 14, 2024

Conversation

devkiloton
Copy link
Owner

@devkiloton devkiloton added the Ready for review Someone must review/reviewed label Jan 14, 2024
@devkiloton devkiloton self-assigned this Jan 14, 2024
Copy link

render bot commented Jan 14, 2024

Copy link
Owner Author

@devkiloton devkiloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 👍🏽

Copy link

github-actions bot commented Jan 14, 2024

Visit the preview URL for this PR (updated for commit defd011):

https://totp-c10e7--pr53-feature-37-a38d33ff.web.app

(expires Sun, 21 Jan 2024 17:58:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d55d83e39eff053f4566af13baa8a8771a2a32c5

@devkiloton
Copy link
Owner Author

devkiloton commented Jan 14, 2024

There's a bunch of warnings in the useEffect deps but I am starting to think about to fix that and make the #49 in a minor, like 0.1.1-alpha. I think that in this minor I'll fix a lot of things.

@devkiloton devkiloton merged commit 4d9fc2b into dev Jan 14, 2024
2 checks passed
@devkiloton devkiloton added Finished and removed Ready for review Someone must review/reviewed labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all the code base have memoization and improve ESLint rules to enforce it
1 participant