Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the user add brazilian fixed incomes indexed with CDI, IPCA, USA stocks and cryptos #46

Merged
merged 135 commits into from
Jan 4, 2024

Conversation

Copy link
Owner Author

@devkiloton devkiloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested (Easy mode)

src/components/root/Main.tsx Outdated Show resolved Hide resolved
src/components/shared/RadialChart.tsx Outdated Show resolved Hide resolved
src/components/shared/Dividends.tsx Outdated Show resolved Hide resolved
src/hooks/use-fuzzy-stocks-us.ts Outdated Show resolved Hide resolved
src/hooks/use-delete-fixed-income.ts Outdated Show resolved Hide resolved
src/hooks/use-add-fixed-income.ts Outdated Show resolved Hide resolved
src/hooks/use-add-crypto.ts Show resolved Hide resolved
src/components/shared/FixedIncomeCard.tsx Outdated Show resolved Hide resolved
src/components/forms/AddStockUSAForm.tsx Outdated Show resolved Hide resolved
src/components/forms/AddFixedIncomeForm.tsx Outdated Show resolved Hide resolved
@devkiloton
Copy link
Owner Author

PS: resolved the problems with the vite build command

@devkiloton devkiloton merged commit 1022767 into dev Jan 4, 2024
2 checks passed
@devkiloton devkiloton changed the title Make the user add brazilian stable investments based indexed with CDI, IPCA, USA stocks and cryptos Make the user add brazilian fixed incomes indexed with CDI, IPCA, USA stocks and cryptos Jan 6, 2024
@devkiloton devkiloton added Partially finished It should be improved later and removed Working on It's in progress labels Jan 6, 2024
@devkiloton
Copy link
Owner Author

devkiloton commented Jan 6, 2024

Tbh, I really think that it was a not my best code, there are minor bugs and it's too much imperative. I'll try to make the code more reusable and create helpers before the 0.1.0-alpha release in the #49 but I can't promise too much. It was an extensive PR that took the christmas, new year and my entire job recess I was feeling too tired and decide to merge with a simple review.

Hope it'll be useful for anyone some day....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partially finished It should be improved later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the user add brazilian fixed incomes indexed with CDI, IPCA, USA stocks and cryptos
1 participant