Updates detection of already-running docker compose instances #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current parsing of textural docker compose ps output assumes `"--------"` will delimit output. This is no longer the case. This PR amends us to use the JSON output formatter. * Adds PsWithJson method to DockerCompose.cs to use within DockerCompose.cs `CheckIfRunning` method. This protects us somewhat from changes to the text output of docker compose ps. * Updates tests. I did consider adding a JSON parser library to parse the output (and would be happy to switch to that), but I did not want to bloat any consuming code bases.
In case anyone was using it.
|
I’m going to merge this as the tests pass and it’s just restoring previously created functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current parsing of textural docker compose ps output assumes
"--------"will delimit output. This is no longer the case. This PR amends us to use the JSON output formatter when invoking docker compose ps.Adds
PsWithJsonmethod toDockerCompose.csto use within theDockerCompose.csCheckIfRunningmethod. This protects us somewhat from future changes to the text output of docker compose ps.Updates tests.
I did consider adding a JSON parser library to parse the output (and would be happy to switch to that), but I did not want to bloat any consuming code bases.