Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Hack in thickness #2409

Closed
wants to merge 1 commit into from
Closed

compiler: Hack in thickness #2409

wants to merge 1 commit into from

Conversation

FabioLuporini
Copy link
Contributor

This is beyond horrible, but it's gonna fixed in #2405

@FabioLuporini FabioLuporini added the bug-C bug in the generated code label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (3024584) to head (6db5f16).

Files Patch % Lines
devito/passes/clusters/implicit.py 58.33% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
- Coverage   86.74%   86.72%   -0.02%     
==========================================
  Files         235      235              
  Lines       44550    44567      +17     
  Branches     8250     8256       +6     
==========================================
+ Hits        38644    38652       +8     
- Misses       5187     5194       +7     
- Partials      719      721       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's as fine as it's going to get, but you should add a test so we can be certain this issue is fixed when I revert the change

@FabioLuporini
Copy link
Contributor Author

Closing as superseded by #2411

@FabioLuporini FabioLuporini deleted the fix-msd-bounds branch July 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-C bug in the generated code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants