compiler: Introduce cluster-level Temp #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
=======================================
Coverage 86.82% 86.83%
=======================================
Files 229 229
Lines 42450 42461 +11
Branches 7870 7870
=======================================
+ Hits 36858 36869 +11
Misses 4933 4933
Partials 659 659 ☔ View full report in Codecov by Sentry. |
FabioLuporini
requested changes
Dec 12, 2023
|
Minor comment left, otherwise GTG. Thanks |
mloubout
approved these changes
Dec 12, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
cluster_temp
branch
from
c4f52a4 to
302e2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A high-order TTI kernel resulted in requiring a mulsort between a "cluster-level" and a "devito" Temp, both having the same name and class name. This fix solves this issue. MFE test added.
Not sure, if we would like to have a TTI so16 kernel to compile in testing