compiler: Add missing numpy dtypes #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2271 +/- ##
=======================================
Coverage 86.91% 86.92%
=======================================
Files 229 229
Lines 42150 42156 +6
Branches 7787 7787
=======================================
+ Hits 36635 36643 +8
+ Misses 4866 4863 -3
- Partials 649 650 +1 ☔ View full report in Codecov by Sentry. |
FabioLuporini
requested changes
Nov 21, 2023
| @@ -649,6 +659,8 @@ class CHARP(CastStar): | |||
| (np.int8, '*'): CHARP, | |||
| (np.uint8, '*'): CHARP, | |||
| (int, '*'): INTP, # noqa | |||
| (np.uint16, '*'): INTP, # noqa | |||
There was a problem hiding this comment.
this should actually be USHORTP (to be added) ?
FabioLuporini
changed the title
FabioLuporini
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.