examples: Add nonzero example to ConditionalDimension tutorial by georgebisbas · Pull Request #1820 · devitocodes/devito

georgebisbas · 2022-01-17T11:30:06Z

Add a "nonzero" example to ConditionalDimension tutorial.

Example to :

Count nonzeros
Return nonzero positions

Continuing from the closed PR: #1815

review-notebook-app · 2022-01-17T11:30:10Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov · 2022-01-17T11:34:38Z

Codecov Report

Merging #1820 (22ac819) into master (543b7be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1820   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files         209      209           
  Lines       34517    34517           
  Branches     5212     5212           
=======================================
  Hits        30908    30908           
  Misses       3117     3117           
  Partials      492      492

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543b7be...22ac819. Read the comment docs.

mloubout · 2022-01-19T15:49:56Z

@@ -71,7 +71,7 @@
     "name": "stderr",


Line #10. i = Scalar(name='i', dtype=np.int32)
That looks weird, what's the actual issue? Can you open an issue for it?

Reply via ReviewNB

This code, if optimized with openmp+ reduction fails with gcc-5:

START_TIMER(section0) for (int x = x_m; x <= x_M; x += 1) { for (int y = y_m; y <= y_M; y += 1) { if (f[x][y] != 0) { int r0 = 1; g[1] += r0; } } } STOP_TIMER(section0,timers)

The trick in the PR helps to generate

int i = 0; /* Begin section0 */ START_TIMER(section0) for (int x = x_m; x <= x_M; x += 1) { for (int y = y_m; y <= y_M; y += 1) { if (f[x][y] != 0) { int r0 = 1; g[i + 1] += r0; } } } STOP_TIMER(section0,timers) /* End section0 */

which is valid. Since we are now in a notebook which is not tested for gcc-5, I can get rid of the trick.
Remember that before it was not in notebook, so this was a problem. DO you think it still deserves an issue?

That's odd code looks sane enough for GCC what the compilation error?

EdCaunt

Looks good to me

FabioLuporini · 2022-01-27T08:39:07Z

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "# Use case C (Count nonzero elements/ Find nonzero positions)\n",


More than a "use case", this is an example.

Also, what the example is about should not end up within parentheses

I tried to be consistent with the rest of the notebook. SOunds good to apply this change to previous use-cases/examples?

FabioLuporini

minor tweaks necessary, but then nearly GTG

FabioLuporini · 2022-02-03T08:17:59Z

+   "source": [
+    "# Example A - Count nonzero elements\n",
+    "\n",
+    "Here we present an of using `ConditionalDimension`. In the following example, an `Operator` counts the nonzero elements of an array."


"an of using" -- to be fixed @georgebisbas

FabioLuporini · 2022-02-03T08:19:07Z

+    "\n",
+    "Here we present another example of using `ConditionalDimension`. In the following example, an `Operator` counts the nonzero elements of an array.\n",
+    "\n",
+    "Now, let's take it a step further to return the nonzero positions in $f$. We know that we have `g.data[0]` nonzero elements. In this example, we use the Devito DSL to generate code that will save the nonzero positions."


shuold be `f` not $f$ , right?

In this example, we use the Devito DSL to generate code that will save the nonzero positions."

background noise, drop

you already have said what you do in the previous paragraph, ie

"In the following example, an Operator counts the nonzero elements of an array."

rewritten, hope its better now.

FabioLuporini

I also think this notebook has grown substantially verbose, as we're printing the whole Operator code, for every Operator in the notebook. Maybe we should only print the relevant section, ie the time loop ...

examples: Add nonzero example to ConditionalDimension tutorial wip

georgebisbas · 2022-02-07T20:38:19Z

I also think this notebook has grown substantially verbose, as we're printing the whole Operator code, for every Operator in the notebook. Maybe we should only print the relevant section, ie the time loop ...

Done. Only the "IMPORTANT" part is now printed. (no time loop in the examples though...!)

FabioLuporini

Now it LGTM. Thanks, merging

georgebisbas added API api (symbolics, types, ...) examples examples labels Jan 17, 2022

georgebisbas requested review from EdCaunt, FabioLuporini, mloubout and rhodrin January 17, 2022 11:30

georgebisbas self-assigned this Jan 17, 2022

georgebisbas force-pushed the nonzero_tutorial branch from cb2739b to c67a0b2 Compare January 17, 2022 13:33

mloubout reviewed Jan 19, 2022

View reviewed changes

EdCaunt reviewed Jan 21, 2022

View reviewed changes

Comment thread examples/userapi/05_conditional_dimension.ipynb

georgebisbas requested a review from EdCaunt January 25, 2022 10:22

georgebisbas changed the title ~~[WIP, RFC] examples: Add nonzero example to ConditionalDimension tutorial~~ examples: Add nonzero example to ConditionalDimension tutorial Jan 25, 2022

EdCaunt reviewed Jan 25, 2022

View reviewed changes

georgebisbas force-pushed the nonzero_tutorial branch from 7d8858b to a381f23 Compare January 25, 2022 15:33

FabioLuporini reviewed Jan 27, 2022

View reviewed changes

Comment thread examples/userapi/05_conditional_dimension.ipynb Outdated

FabioLuporini requested changes Jan 27, 2022

View reviewed changes

georgebisbas force-pushed the nonzero_tutorial branch from a381f23 to feee2e3 Compare January 27, 2022 13:31

georgebisbas requested review from EdCaunt and FabioLuporini February 2, 2022 11:51

FabioLuporini reviewed Feb 3, 2022

View reviewed changes

George Bisbas added 2 commits February 7, 2022 20:22

examples: Add nonzero example to ConditionalDimension tutorial

0c39cf2

examples: Add nonzero example to ConditionalDimension tutorial wip

examples: revert gcc-5 turnaround

c3caa01

georgebisbas force-pushed the nonzero_tutorial branch from feee2e3 to 49f8c13 Compare February 7, 2022 20:23

georgebisbas requested a review from FabioLuporini February 7, 2022 20:24

examples: reduce verbosity, update comments

22ac819

georgebisbas force-pushed the nonzero_tutorial branch from 49f8c13 to 22ac819 Compare February 7, 2022 20:36

georgebisbas removed the API api (symbolics, types, ...) label Feb 7, 2022

FabioLuporini approved these changes Feb 8, 2022

View reviewed changes

FabioLuporini merged commit e2321f4 into master Feb 8, 2022

FabioLuporini deleted the nonzero_tutorial branch February 8, 2022 07:55

Uh oh!

Conversation

georgebisbas commented Jan 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app Bot commented Jan 17, 2022

Uh oh!

codecov Bot commented Jan 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EdCaunt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FabioLuporini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FabioLuporini left a comment

Choose a reason for hiding this comment

Uh oh!

georgebisbas commented Feb 7, 2022

Uh oh!

FabioLuporini left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

georgebisbas commented Jan 17, 2022 •

edited

Loading

codecov Bot commented Jan 17, 2022 •

edited

Loading