Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round 1 of Rubocop cleanup #367

Merged
merged 31 commits into from
Jun 21, 2022
Merged

Round 1 of Rubocop cleanup #367

merged 31 commits into from
Jun 21, 2022

Conversation

dillonwelch
Copy link
Contributor

No description provided.

@dillonwelch dillonwelch added this to the 0.18.0 milestone Dec 29, 2021
@coveralls
Copy link
Collaborator

coveralls commented Dec 29, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-97.9%) to 0.0% when pulling f68d604 on dillonwelch:rubocop-cleanup into 4213231 on devise-security:master.

@olbrich
Copy link
Contributor

olbrich commented Dec 29, 2021

You may want to merge #364 before you get too far along with updating. I'm sure some new cops will be introduced.

@dillonwelch
Copy link
Contributor Author

Is that one good to go?

@dillonwelch
Copy link
Contributor Author

@olbrich updated with the necessary changes from the minitest cops!

@dillonwelch dillonwelch merged commit 14a4dcb into devise-security:master Jun 21, 2022
@dillonwelch dillonwelch deleted the rubocop-cleanup branch June 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olbrich olbrich Awaiting requested review from olbrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dillonwelch @coveralls @olbrich